opencv 4.6.0 with related migrations to jpeg-turbo, python@3.10, and ffmpeg#107250
Closed
cho-m wants to merge 11 commits intoHomebrew:masterfrom
Closed
opencv 4.6.0 with related migrations to jpeg-turbo, python@3.10, and ffmpeg#107250cho-m wants to merge 11 commits intoHomebrew:masterfrom
jpeg-turbo, python@3.10, and ffmpeg#107250cho-m wants to merge 11 commits intoHomebrew:masterfrom
Conversation
jpeg-turbo and python@3.10
jpeg-turbo and python@3.10jpeg-turbo and python@3.10
This comment was marked as resolved.
This comment was marked as resolved.
cho-m
commented
Aug 3, 2022
cho-m
commented
Aug 3, 2022
cho-m
commented
Aug 3, 2022
jpeg-turbo and python@3.10jpeg-turbo and python@3.10
2eddfe3 to
8995269
Compare
cho-m
commented
Aug 4, 2022
Formula/opencv.rb
Outdated
Comment on lines
59
to
81
Member
Author
There was a problem hiding this comment.
Remaining directories:
carotene cpufeatures ippicv ittnotify libtengine libtim-vx openvx quirc
include/opencl
include/vulkan
Some aren't used (like cpufeatures is Android-only) and Vulkan is disabled by default. Others aren't formulae like Intel libraries.
cho-m
commented
Aug 4, 2022
8995269 to
cfdd1fd
Compare
jpeg-turbo and python@3.10jpeg-turbo, python@3.10, and ffmpeg
This comment was marked as resolved.
This comment was marked as resolved.
cfdd1fd to
481851d
Compare
cho-m
commented
Aug 8, 2022
Formula/mlt.rb
Outdated
Member
Author
There was a problem hiding this comment.
I think this is related to mltframework/mlt#810
cho-m
commented
Aug 8, 2022
6 tasks
6 tasks
481851d to
e20a427
Compare
8aa446b to
25acf9f
Compare
25acf9f to
1bdb314
Compare
cho-m
commented
Aug 14, 2022
Comment on lines
+138
to
143
| # Ref: https://github.com/opencv/opencv/wiki/CPU-optimizations-build-options | ||
| ENV.runtime_cpu_detection | ||
| if Hardware::CPU.intel? && build.bottle? | ||
| cpu_baseline = MacOS.version.requires_sse42? ? "SSE4_2" : "SSSE3" | ||
| args += %W[-DCPU_BASELINE=#{cpu_baseline} -DCPU_BASELINE_REQUIRE=#{cpu_baseline}] | ||
| end |
Member
Author
There was a problem hiding this comment.
I think for non-bottle builds, it should:
- on Linux,
-march=nativeshould force CPU detection
https://github.com/opencv/opencv/blob/4.6.0/cmake/OpenCVCompilerOptimizations.cmake#L162-L166 - on macOS, the default is auto-detection
https://github.com/opencv/opencv/blob/4.6.0/cmake/OpenCVCompilerOptimizations.cmake#L319-L321
Member
There was a problem hiding this comment.
This might need adjusting for source builds, then, since ENV.runtime_cpu_detection will skip passing any -march flags.
Member
Author
There was a problem hiding this comment.
In that case, Linux install will probably be similar between bottles and source build as SSE3 is default baseline which should give same result as SSSE3.
There is a CPU_BASELINE=NATIVE which I didn't see any documentation on but may provide a more tuned variant for host system.
Member
There was a problem hiding this comment.
I'm ok to set CPU_BASELINE=NATIVE if we're not building bottles as long as it doesn't lead to dependent weirdness as with the Facebook formulae.
cho-m
commented
Aug 15, 2022
107f404 to
0f186bd
Compare
carlocab
previously approved these changes
Aug 15, 2022
carlocab
previously approved these changes
Aug 15, 2022
Member
carlocab
left a comment
There was a problem hiding this comment.
Only audit failures for mlt.
Contributor
Contributor
bottle publish failed
carlocab
approved these changes
Aug 15, 2022
Member
carlocab
left a comment
There was a problem hiding this comment.
Forgot to pass --no-autosquash.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Migrations for
vtk,opencv,gdal,mapserver,mlt,ffms2,visp,mapnik