Skip to content

gdcm,vtk@8.2: migrate to python@3.10#106947

Closed
branchv wants to merge 2 commits intoHomebrew:masterfrom
branchv:gdcm
Closed

gdcm,vtk@8.2: migrate to python@3.10#106947
branchv wants to merge 2 commits intoHomebrew:masterfrom
branchv:gdcm

Conversation

@branchv
Copy link
Copy Markdown
Member

@branchv branchv commented Jul 30, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Jul 30, 2022
@branchv branchv added the long build Set a long timeout for formula testing label Jul 30, 2022
@carlocab carlocab added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jul 31, 2022
@carlocab
Copy link
Copy Markdown
Member

Seems to crash when it tries to run vtkpython.

@carlocab carlocab removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jul 31, 2022
@cho-m
Copy link
Copy Markdown
Member

cho-m commented Aug 3, 2022

I was looking into vtk and hit same issue, which I found was lack of Python 3.10 support in current stable release. At least for vtk v9, there is a fix https://gitlab.kitware.com/vtk/vtk/-/merge_requests/8738 that can either be patched or will be available in 9.2.0.

We could try to backport it to v8 or just keep on python@3.9.

@carlocab
Copy link
Copy Markdown
Member

carlocab commented Aug 3, 2022

I don't mind keeping it on python@3.9. But if you're keen to backport the patch, I'm okay with that too.

@cho-m
Copy link
Copy Markdown
Member

cho-m commented Aug 3, 2022

I also think python@3.9 is fine given that we are trying to re-deprecate (and ultimately remove) vtk@8.2

I would like to get vtk@8.2 migrated to jpeg-turbo since that should be a drop-in. Maybe at same time as itk.


For current vtk, I am looking into backporting Python 3.10 patch with something like following, but need to check how bad dependency tree migration is (e.g. opencv, gdal, ...). Particularly trying to avoid pulling in formulae with gobject-introspection, if possible.

    # Fix vtkpython support for Python 3.10. Remove in the next release.
    # First patch backports part of older commit so we can directly patch in upstream commit.
    patch :DATA
    patch do
      url "https://gitlab.kitware.com/vtk/vtk/-/commit/3eea0e12acfb608a76d6ae36fb36566a4a6b0e9b.diff"
      sha256 "1c1c4622a58f8c852d196759c8d9036e4d513a5ebe16fe0bfa14583832886572"
    end

...

__END__
diff --git a/Documentation/release/dev/python-3.10-wheels.md b/Documentation/release/dev/python-3.10-wheels.md
new file mode 100644
index 0000000000000000000000000000000000000000..f4e81411c73f30724ad420ccb7f3c6c07a6f8e3d
--- /dev/null
+++ b/Documentation/release/dev/python-3.10-wheels.md
@@ -0,0 +1,7 @@
+## Python 3.10 wheels
+
+VTK now generates Python 3.10 wheels. Note that `vtkpython` and other tools
+using `vtkPythonInterpreter` still do not support the new initialization
+behaviors introduced in Python 3.10. See [this issue][vtk-python-3.10-support].
+
+[vtk-python-3.10.support]: https://gitlab.kitware.com/vtk/vtk/-/issues/18317

depends_on "openssl@1.1"
depends_on "python@3.9"
depends_on "python@3.10"
depends_on "vtk@8.2"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be worth checking what features we lose by dropping VTK support. Fedora and AUR (and maybe FreeBSD, not sure of DSL they use) has disabled VTK. NixOS defines VTK as optional.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #107657 for this approach

@branchv
Copy link
Copy Markdown
Member Author

branchv commented Aug 15, 2022

Closing in favor of #107657

@branchv branchv closed this Aug 15, 2022
@branchv branchv deleted the gdcm branch August 15, 2022 20:56
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing outdated PR was locked due to age python Python use is a significant feature of the PR or issue python-3.10-migration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants