Skip to content

remove cask/cmd/install #15273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MikeMcQuaid merged 4 commits into from
Apr 19, 2023
Merged

remove cask/cmd/install #15273

MikeMcQuaid merged 4 commits into from
Apr 19, 2023
+99 −633

Conversation

@hyuraku
Copy link
Contributor

@hyuraku hyuraku commented Apr 19, 2023 •
edited by MikeMcQuaid
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

remove cask/cmd/install and cask/cmd because of #14799

Fixes #14799

MikeMcQuaid
MikeMcQuaid reviewed Apr 19, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Looks good so far, one small question.

MikeMcQuaid
MikeMcQuaid approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @hyuraku, great work getting this whole issue completed!

@MikeMcQuaid MikeMcQuaid merged commit 7a3376c into Homebrew:master Apr 19, 2023
@MikeMcQuaid MikeMcQuaid mentioned this pull request Apr 19, 2023
Closed
7 tasks
@dduugg dduugg mentioned this pull request Apr 19, 2023
Merged
7 tasks
@KaiHoewelmeyer-TomTom KaiHoewelmeyer-TomTom mentioned this pull request Apr 23, 2023
Closed
5 tasks
@kaihowl kaihowl mentioned this pull request Apr 23, 2023
Closed
3 tasks
apainintheneck added a commit to apainintheneck/brew that referenced this pull request Apr 23, 2023
@apainintheneck
cmd/install: warn on cask install when already installed
d9996c0 
This was the default behavior before Homebrew#15273 got merged in to
refactor the `cask/cmd/install` logic into `cmd/install`.
apainintheneck added a commit to apainintheneck/brew that referenced this pull request Apr 23, 2023
@apainintheneck
cmd/install: warn on cask install when already installed
e82867a 
This was the default behavior before Homebrew#15273 got merged in to
refactor the `cask/cmd/install` logic into `cmd/install`.
@apainintheneck apainintheneck mentioned this pull request Apr 23, 2023
Merged
7 tasks
SMillerDev pushed a commit to SMillerDev/brew that referenced this pull request Apr 26, 2023
@apainintheneck @SMillerDev
cmd/install: warn on cask install when already installed
a2b3b8b 
This was the default behavior before Homebrew#15273 got merged in to
refactor the `cask/cmd/install` logic into `cmd/install`.
@github-actions github-actions bot added the outdated PR was locked due to age label May 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Bo98 Bo98 Bo98 left review comments

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees

No one assigned

Labels

outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove all Library/Homebrew/cask/cmd/* files

3 participants

@hyuraku @MikeMcQuaid @Bo98