Skip to content

Difficulty: CuccosToReturn#5552

Merged
Malkierian merged 3 commits intoHarbourMasters:developfrom
serprex:difficult-cucco
Jun 11, 2025
Merged

Difficulty: CuccosToReturn#5552
Malkierian merged 3 commits intoHarbourMasters:developfrom
serprex:difficult-cucco

Conversation

@serprex
Copy link
Contributor

@serprex serprex commented Jun 1, 2025

Replaces rando option

Request 25 in #5481

Build Artifacts

@serprex serprex force-pushed the difficult-cucco branch 2 times, most recently from 214b433 to 2c399d4 Compare June 1, 2025 18:44
Mirrors rando option
Copy link
Contributor

@briaguya0 briaguya0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like this will make it so the enhancement slider exists and can be interacted with when playing a rando seed but won't do anything in that case - i feel like that may be confusing

@Pepper0ni
Copy link
Contributor

The rando setting could be removed with this enhancment, at least until strength 0 is shuffled, as chicken count has no logical effect.

@Malkierian
Copy link
Contributor

Now that it's mentioned, I've never really understood why it was a rando setting to begin with, honestly. We don't have any checks for cucco counts in logic code regardless, so it's kind of pointless there.

@Malkierian
Copy link
Contributor

In which case, the hook could be changed to something about VB_SHOULD_GIVE_CUCCO_REWARD instead of arbitrarily setting the cucco count. However, it's likely that that could be considered out of scope for this PR.

@serprex
Copy link
Contributor Author

serprex commented Jun 1, 2025

based on discussion on discord I've added a commit which removes RSK_CUCCO_COUNT while requiring rando to require at least 1 cucco in pen to futureproof against str0

@serprex serprex force-pushed the difficult-cucco branch from 7c09141 to 1ca27ba Compare June 5, 2025 00:41
@Malkierian Malkierian merged commit 52debea into HarbourMasters:develop Jun 11, 2025
6 checks passed
krazyjakee pushed a commit to krazyjakee/OOT that referenced this pull request Sep 6, 2025
* Difficulty: CuccosToReturn

Mirrors rando option

* remove RSK_CUCCO_COUNT

* revert forcing rando to at least 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants