Conversation
c3b0069 to
85e2087
Compare
|
I hit 14/15/16 when I run around bonking trees, can you try changing your coordinate to the coordinates in ShuffleTrees.cpp? |
|
I finally understood they are exclusive to children's age and not adult so logic problem |
|
Thanks for testing this, logic updated |
|
I confirm that there are the 3 shafts miss that they appeared following your update I have an idea to offer you but I don't know if it's frightening but you think it is possible that the tree that they are child and adult you could separate them to increase the number of checks? |
|
I would prefer not to do that, as it contradicts other shuffles & lookup based on X/Z coordinates would need to be adjusted |
|
OK, no problem |
Pepper0ni
left a comment
There was a problem hiding this comment.
A few fixes and comments. It would also be nice to have always hints for the NL trees when they are on, but I wouldn't block over that.
soh/soh/Enhancements/randomizer/location_access/overworld/kakariko.cpp
Outdated
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/location_access/overworld/castle_grounds.cpp
Outdated
Show resolved
Hide resolved
|
Were you aware of #5003 when making this? |
|
Yes he knows how to look at the first message he put at the beginning |
|
As stated in the OP, this was a deliberate re-implementation because the old branch was stale and the dev unresponsive. |
|
I assume the |
|
@Malkierian correct, lots of copy pasting |
fc796fe to
169e6df
Compare
Pepe20129
left a comment
There was a problem hiding this comment.
Did a run and found no issues with functionality, some small suggestions.







Updated #5003 with latest dev (by hand, because merge conflict hell)
Extended to all trees in HF
Cleaned up code
Build Artifacts