[Rando] Treesanity, randomizing overworld trees.#5003
[Rando] Treesanity, randomizing overworld trees.#5003turbofist wants to merge 55 commits intoHarbourMasters:developfrom
Conversation
…o develop Merge message
…into develop Merging upstream.
…into develop Merge upstream.
soh/soh/Enhancements/randomizer/location_access/overworld/lon_lon_ranch.cpp
Outdated
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/location_access/overworld/zoras_fountain.cpp
Outdated
Show resolved
Hide resolved
|
Noticed I was using the wrong hint format for some checks, fixed that as well. |
Moved tree locations to separate file.
|
Just finished up the last thing I wanted to work on, trees instantly reverting to their normal appearance once a check has been collected, if there are no other remarks I feel finished with the first iteration of treesanity. |
|
@turbofist on discord someone was asking about trees:
|
This is intended, these trees are not recognized as individual actors as they are spawned from other actors, I will see if there is something that can be done about this eventually, and I will make this more clear in the rando menu description. |
…g why some trees are intentionally not randomized.
|
just giving you a bump to make sure you know that thanks to clang-format there are probably significant conflicts to fix, but I'm in a position where I can review and test this soon |
|
According to multiple user reports, checks for Tree in Northwest HF 2, Tree in South East HF 4, Tree in HF near Grotto are bugged. |
| } else if (this->actor.home.rot.z != 0) { | ||
| this->actor.home.rot.z &= 0x1FFF; | ||
| this->actor.home.rot.z |= 0xE000; | ||
| if (GameInteractor_Should(VB_TREE_DROP_ITEM, true, this)) { |
There was a problem hiding this comment.
this should probably be false, as it's running code in non-rando it shouldn't
| } | ||
| } else { | ||
| Item_DropCollectibleRandom(play, &this->actor, &dropsSpawnPt, this->unk_14C << 4); | ||
| if (GameInteractor_Should(VB_TREE_DROP_ITEM, (this->unk_14C >= 0) && (this->unk_14C < 0x64), this)) { |
There was a problem hiding this comment.
this condition does not exist in original code
|
Closing since this was rolled into #5541. Credit will be given in the PR merge there. |
Adds Treesanity, shuffles items into trees, roll into them to obtain the item.
Trees have a special appearence when holding items.