entrance shuffle: sign hints#5335
Conversation
|
The spoiled state of an entrance should already be handled somewhere with the entrance tracker. |
No, this PR makes it so when you talk to a sign (mostly non-cuttable arrow signs) it'll hint the entrance to you. Marking it spoiled would be similar to #4568 |
|
Ah, I see. |
|
waiting on #5363 to update this PR with tracker integration |
|
This is now in a state where it could be merged |
Malkierian
left a comment
There was a problem hiding this comment.
I agree that this should just be automatic and not be a setting.
|
Need to test how this handles mixed entrances where destination is grotto because grotto entrance IDs are weird |
|
Tested with grottos. Works |
Pepe20129
left a comment
There was a problem hiding this comment.
The text names could be more descriptive
|
Pablo has a point, some of those text enum names are too vague, like the TEXT_DMT_DMT one. Make them a bit more descriptive, and I'll get this merged. |
|
Thanks, will look into when I'm home next week |
|
TEXT_DMT_DMT is a little weird since it's a sign halfway up DMT that just says "Death Mountain Trail". Adding going with |
This makes it so signs by entrances will say where the exit leads to rather than where it leads to in vanilla
Particularly useful with decoupled entrances
Build Artifacts