update check tracker when actor tells what they reward#4568
update check tracker when actor tells what they reward#4568Malkierian merged 2 commits intoHarbourMasters:developfrom
Conversation
|
Honestly, the approach looks fine. Tying it into the messagebox system was pretty clever, and you made sure to also evaluate the relevant hint setting being active. The one thing I could suggest you look into is whether any or all of those are affected by mysterious item shuffle. I believe the scrubs are, at least, and maybe the merchants, but I'm not sure about any of the other hints. This shouldn't reveal anything that isn't normally in the text boxes if the player has mysterious shuffle enabled. |
835260d to
f03aed9
Compare
|
PR updated to account for merchant mystery. Also added rest of static hints |
There was a problem hiding this comment.
The Loach hint has been overlooked and should be added.
Mysterious items current affect merchants and scrubs, but not static hints. Personally, I don't think mysterious items shouldn't affect hints because if the player wanted no hints, they would not have switched on the hint settings in the first place. This is an extension of my issues with the mysterious items implementation though and nothing to do with this PR. All I'll ask of this is to patch up the issues I found in testing.
5d84a7f to
e51a66e
Compare
do not render price when 0
e51a66e to
cfe14a1
Compare
Don't render 0 when item has no price
Build Artifacts