Port Over Nametag improvements#5160
Merged
briaguya0 merged 1 commit intoHarbourMasters:developfrom May 17, 2025
Merged
Conversation
517c6f7 to
2f63c48
Compare
2f63c48 to
5b14cf5
Compare
Malkierian
approved these changes
May 13, 2025
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports over some of the improvements from the 2ship Nametags PR HarbourMasters/2ship2harkinian#746
Copying the relevant details here:
OnActorDestroy- Called right before an actor is freed from the arena. When actors are removed via room transitions, they will not always callActor_Kill, butActor_Destroywill always be called in both cases.OnActorDestroyis a better hook to use overOnActorKillBuild Artifacts