Replace old methods with ShipUtils#5151
Merged
Archez merged 2 commits intoHarbourMasters:developfrom Mar 30, 2025
Merged
Conversation
leggettc18
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This drops some old custom methods that we sprinkled through some of the game source files with ShipUtil variants (that were brought over from 2ship in the menu PR).
The main "change" was the old font width method was applying a scale internally, and then consumers were reverting that scale. Instead I've dropped that and moved the additional scale directly to the
Interface_DrawTextLinemethod.I didn't bother moving
Interface_DrawTextLineas that does a bit more than just "utility" logic (graphics rendering, etc), so that can be done in a follow up PR.Build Artifacts