Refactor Hint Creation and add support for hint Copies and fixed number of hints.#3205
Merged
garrettjoecox merged 24 commits intoHarbourMasters:develop-randofrom Nov 2, 2023
Merged
Conversation
Contributor
|
@Pepper0ni was the LUS update intentional? Seems like that should probably go in separately, I can't imagine it enables any of the other changes |
Contributor
Author
|
Bad submodule conflict handling, and trying to do it properly may have just destroyed a separate PR. Am going back to this once I have figured out exactly what state that screwup left me in |
Contributor
It looks like that might just be the last commit that's the culprit, you could just try resetting that last commit |
032fb64 to
a4e6da7
Compare
…song shuffle text from spoiler logs
…eing hinted elsewhere unless they are locked by that item.
…ial final frogs hint is enabled.
…ial final frogs hint is enabled.
…, expand LightArrow hint category into OtherHint category.
Pepper0ni
added a commit
to Pepper0ni/Shipwright
that referenced
this pull request
Oct 27, 2023
Pepper0ni
added a commit
to Pepper0ni/Shipwright
that referenced
this pull request
Nov 4, 2023
Pepper0ni
added a commit
to Pepper0ni/Shipwright
that referenced
this pull request
Nov 9, 2023
Pepper0ni
added a commit
to Pepper0ni/Shipwright
that referenced
this pull request
Nov 16, 2023
Pepper0ni
added a commit
to Pepper0ni/Shipwright
that referenced
this pull request
Nov 30, 2023
Pepper0ni
added a commit
to Pepper0ni/Shipwright
that referenced
this pull request
Dec 7, 2023
leggettc18
pushed a commit
that referenced
this pull request
Dec 7, 2023
…um and other cleanups (#3339) * Initial wothCandidates change, pushed early foreseeing conflicts * Implement better barren handling, waiting on #3205 * pls save next time VS code * Finish implementation of barren and randomizer area refactor * Apply function changes to develop merge * Fix double default decleration issue * change some var types for uniformity * Fix post merge differences to the point of building and generating randos * Address reviews * address more reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid conflicts, This commit includes #3060. It is intended for that to be reviewed and merged in first, or to be skipped altogether in favour of this. This PR is to bring awareness of my other work relying on it, so this can have have more eyes on it for longer, and for closure on my end.
A refactor of hints.cpp designed to minimise copied code and implement some unimplemented features.
User-facing features:
Codebase changes:
Build Artifacts