Move Barren handling to before hint generation, Add RandomizerArea enum and other cleanups#3339
Merged
leggettc18 merged 10 commits intoHarbourMasters:develop-randofrom Dec 7, 2023
Merged
Conversation
026037b to
cdf8cb6
Compare
61a8bbe to
f9c9df3
Compare
f9c9df3 to
4ea4b50
Compare
Contributor
|
Sorry I think I introduced some merge conflicts here. It shouldn't be anything too major. Mostly just some semantic correctness stuff rather than any functionality changes. |
leggettc18
requested changes
Dec 6, 2023
Contributor
leggettc18
left a comment
There was a problem hiding this comment.
Looks good! I see a few things here that should be changed but nothing major.
leggettc18
approved these changes
Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full changelist
Build Artifacts