give em to the distro packagers#3040
give em to the distro packagers#3040Alto1772 wants to merge 6 commits intoHarbourMasters:develop-sulufrom
Conversation
|
You can update the LUS submodule reference in this PR to point to your LUS changes so that these builds will actually complete and can be tested directly. |
e91276a to
d53b337
Compare
d53b337 to
64ed4f6
Compare
|
once #3113 is merged, this one should be updated to use latest LUS (so the diff shows no LUS changes) and then it should be good to go |
|
@briaguya-ai if we just merge this one first and then #3113 that should just work without any need to update submodules right? |
|
if we merge this first then immediately bump LUS to latest we should be fine (but we'll have a strange commit with a PR version of LUS in the history) |
|
Oh if it's about not having a tagged LUS submodule sha in the repo then yeah we should probably do it the way you suggested. I didn't think about that. |
|
It's not about the tag so much as about it not being an upstream LUS commit at all |
|
It's probably worth it for someone to pull this into a new branch with an LUS bump and get it merged |
|
@Alto1772 are you available to update the LUS submodule on this branch? The one currently on develop-sulu now should have the changes you need. |
* implement for install method packagers * use std::filesystem::temp_directory_path * absolutely impeccable * include libultraship proof * fix windows compilation * rename "Installation" back to "Bundle" --------- Co-authored-by: Alto1772 <56553686+Alto1772@users.noreply.github.com>
|
Closing since these changes made it in via #3119 |
This depends on Kenix3/libultraship#307
Some changes noted:
Extractor::CallZapd()creates OTR file in the temporary directory first and then puts it in the folder where the game is located, or in the user configurations, according to the output of LocateFileAcrossAppDirs. This does not copy soh.otr as it's pretty much useless when theassets/gamefolder missing.shipandextractorrespectively for use within Linux distribution packagers. Reason is compatibility for this AUR package as the base game and extractor was and still is originally going to be seperate. Use commandcmake --install build-cmake --component ship && cmake --install build-cmake --component extractortogether. Will not affect Appimage building.Requires having soh.otr ONLY to test generating other OTR files.
Build Artifacts