Skip to content

Update libultraship (OpenGL window position fix)#3113

Merged
leggettc18 merged 1 commit intoHarbourMasters:develop-sulufrom
Spodi:bump-LUS-sulu
Aug 13, 2023
Merged

Update libultraship (OpenGL window position fix)#3113
leggettc18 merged 1 commit intoHarbourMasters:develop-sulufrom
Spodi:bump-LUS-sulu

Conversation

@Spodi
Copy link
Contributor

@Spodi Spodi commented Aug 11, 2023

  • Fixed window pos not restored with OpenGL
  • Fixed fullscreen in OpenGL (again)
    Fixes going full screen on the next monitor when the game was on the second half of the screen.
  • Set Fullscreen state only when call succeeds
    Also some logging so we hopefully know why it failed.
  • Consistent behavior for getting monitor
    SDL always gets the monitor at the middle of the window. Now DXGI does too. Also only resets the position if there is no pixel of the window on any screen.
  • also get current monitor on resize (DirectX)

Build Artifacts

Copy link
Contributor

@briaguya0 briaguya0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@leggettc18 leggettc18 merged commit fafd35c into HarbourMasters:develop-sulu Aug 13, 2023
@Spodi Spodi deleted the bump-LUS-sulu branch October 3, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants