Fix killer door textures#1177
Merged
briaguya0 merged 2 commits intoHarbourMasters:developfrom Oct 21, 2022
Merged
Conversation
Collaborator
I'd rather have authentic behaviour, even if it means that Child Link can't use Hookshot and Adult Link can't use Deku Sticks. The proposal in #616 is definitely the right answer. If we really want to keep those special cases, we can load the Adult and Child objects at all times. |
briaguya0
approved these changes
Oct 21, 2022
Contributor
|
since we decided against bringing back authentic object dependency this can go in |
th-2021
pushed a commit
to th-2021/Shipwright-cmake
that referenced
this pull request
Nov 28, 2022
* Fix killer door textures * Remove todo as requested by @Rozelette
th-2021
pushed a commit
to th-2021/Shipwright-cmake
that referenced
this pull request
Nov 28, 2022
* Fix killer door textures * Remove todo as requested by @Rozelette
th-2021
pushed a commit
to th-2021/Shipwright-cmake
that referenced
this pull request
Nov 28, 2022
* Fix killer door textures * Remove todo as requested by @Rozelette
th-2021
pushed a commit
to th-2021/Shipwright-cmake
that referenced
this pull request
Nov 28, 2022
* Fix killer door textures * Remove todo as requested by @Rozelette
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround to fix #263.
This may not be the ideal solution. #616 proposes reinstating the original N64 object dependency, but that has its own drawbacks, like crashes when using wrong-age equipment.
I think no matter what the solution ends up being, it will probably involve making hotfixes to various behaviors. It's either workarounds for issues caused by the current behavior, or undo object dependency changes and make workarounds for the issues caused by that instead.
Left a comment noting the workaround, ala the similar #615.
EDIT: Additional note:
As far as I know, fake doors only appear in the Fire Temple (where they use the
HIDAN[Fire Temple] metal door texture), Spirit Temple and Gerudo Training Ground (where they use the defaultGAMEPLAY_KEEPwooden door texture).The killer door object is also set up to handle using the
MIZU(Water Temple) andHAKA(Shadow Temple) textures even though they don't seem to occur in those areas. Maybe they do appear in Master Quest, or maybe they were removed from those areas during development, or maybe they were just covering their bases in case they ever did want to use them.This workaround replicates that original behavior, so fake doors should display with dungeon-appropriate textures if forcibly spawned in those locations.