Fix CS issues that was found by Travis#15
Closed
zero-24 wants to merge 1 commit intoHackwar:com_contact_router_legacyfrom
zero-24:patch-26
Closed
Fix CS issues that was found by Travis#15zero-24 wants to merge 1 commit intoHackwar:com_contact_router_legacyfrom zero-24:patch-26
zero-24 wants to merge 1 commit intoHackwar:com_contact_router_legacyfrom
zero-24:patch-26
Conversation
https://travis-ci.org/joomla/joomla-cms/jobs/44968050 @Hackwar This fix the two CS issues by travis for: see: joomla#5502
Author
Owner
|
Sorry, I saw your first PR and since it was in the other 2, too, I fixed those instead directly myself. Thank you anyway. |
Author
|
no Problem 😄 |
Hackwar
pushed a commit
that referenced
this pull request
Jun 28, 2016
…oomla#10424) * Update icon.php * Update default_core.php * Update mod_articles_categories.php * Update default.php * Update compare.php * Update default_url.php * Update mod_tags_popular.php * Update modules.php * Update frontediting_modules.php * Update index.php * Update component.php * fixes (#15) * revert name change
Hackwar
pushed a commit
that referenced
this pull request
Sep 3, 2016
* Initial test environment setup with Jasmine, Karma and RequireJS * Seperated test setup code from test logic * Configured .travis.yml to run Karma * Fixed typo in .travis.yml * changes to .travis.yml * Added karma requirejs module * Removed unnecessary code in travis.yml * Fixed missing code is travis.yml * Removed 2 unused image files * Improved code standards * Modified travis.yml * Issue 1 Cleaned the mess with changes bunch of to unrelated files * Issue 1 Added newline at end of file * Issue 4 Improved JCaption JavaScript tests * New coeverage reporter plugin test with Travis * Issue 1 Added karma-coerage reporter and configured it to display coverage on console * Issue 1 Added and configured karma-verbose-reporter plugin * Issue 1 Fixing verbose reporter config for travis * Issue 1 removed redundant javascript dir and added requirejs/text plugin to load fixtures * Issue 4 Improved code with suggestions made in the code review * Issue 1 Added version for requirejs text plugin * Issue 1 converted space indentations to tabs * Issue 1 Fixed indentation in package.json * Issue 1 Fixed version issue in require text * Issue 1 Fixed version issue in require text * Issue 1 Fixed version issue in require text * Issue 4 Improved code standards and jquer selector efficiency * Issue 1 Tersting version issue with text plugin on travis * Issue 1 Tersting version issue with text plugin on travis * Issue 1 Tersting version issue with text plugin on travis * Issue 1 Removed spec folder * Corejs tests (#15) Tests for core.js * Tests for permissions.js (#13) * Test suite for permissions.js * Added karma-jasmine-ajax plugin * Added a container div for fixtures representing library name (#11) * Added a container div for fixtures representing the library name * CS - Removed an extra new line * Permissions.js tests Test for permissions * Repeatable.js test suite * Improvements to JCaption tests * README.md update * Modified readme file * Made running tests easier by adding configuration for tests to run on npm test * Core js Improvements * Issue 9 Added jasmine spies and improved code * Issue 9 Fixed an indentation issue * Demo video on Youtube * Inserted the video demonstration link to the readme * Issue 5 Added spies and made code improvements (#31) * Issue 12 Improved code (#34) * Repeatable.js Improvements (#35) * Run Travis JavaScript tests on separated Matrix Build (#39) * Only run Travis tests on PHP 7 * Fix base path issue * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Reverted README.md * Synced README.md to the new version * Synced README.md with new version * Fixed indentations * Synced README.md with 3.6 version * Fixed indentations * Fixed indentations * Added newline at the end of travis-tests.sh * Added missing sudo:false in .travis.yml
Hackwar
pushed a commit
that referenced
this pull request
Mar 15, 2019
Hackwar
pushed a commit
that referenced
this pull request
Dec 28, 2021
* Add some events when fetching media data * Use dispatcher to trigger event * Use an event instance * Class per event (#15) * Argument validations and getter (#16) * Class per event * Argument validations * global * Use result from events * Copy year * Use internal variable * void * adapt model * Validate events (#17) * Revert commit ec8b4c8 ccd02cb and 9a2a119 * Validate and immutable events * Update administrator/components/com_media/src/Event/FetchMediaFileEvent.php Co-authored-by: Harald Leithner <leithner@itronic.at> * Update administrator/components/com_media/src/Event/FetchMediaFilesEvent.php Co-authored-by: Harald Leithner <leithner@itronic.at> * Rename the events * Cleanup events Co-authored-by: Fedir Zinchuk <getthesite@gmail.com> Co-authored-by: Harald Leithner <leithner@itronic.at>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://travis-ci.org/joomla/joomla-cms/jobs/44968050
@Hackwar This fix the two CS issues by travis for: see: joomla#5502