Corrections for MySQL and PostgreSQL for Joomla CMS PR #25760#31
Merged
Hackwar merged 3 commits intoHackwar:j4mysql8contentfrom Aug 1, 2019
Merged
Corrections for MySQL and PostgreSQL for Joomla CMS PR #25760#31Hackwar merged 3 commits intoHackwar:j4mysql8contentfrom
Hackwar merged 3 commits intoHackwar:j4mysql8contentfrom
Conversation
This reverts commit 0dab899.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See my first comment in your PR joomla#25760.
I've tested with MySQL 5.7 that it really needs that to make the db checker not run into an SQL error when checking.
Maybe all would be easier if we just would make a PR to remove the db checker/fixer.
What remains to be done: There is no ISNULL() function in PostgreSQL. This function is a MySQL special. Therefore either use standard "IS NULL" statement which works in both and like I had it in this PR with the 2nd commit which I reverted then, or get a query object and use
$query->isNullDatetime(...), which would also help with old data after broken updates where the UPDATE statement in the schema update were not executed by the DB fixer when trying to fix that .