Improve settings model fetching and question notebook lookup UX#523
Closed
wyr-zal wants to merge 1 commit into
Closed
Improve settings model fetching and question notebook lookup UX#523wyr-zal wants to merge 1 commit into
wyr-zal wants to merge 1 commit into
Conversation
- Add a settings API and UI picker for fetching provider model lists - Allow adding a service profile when no profile is configured - Let question notebook lookup silently return empty results for unsaved questions - Deduplicate quiz notebook lookup calls to avoid repeated 404 noise - Add related API tests and English/Chinese locale strings
Collaborator
|
Thanks for your contribution! Both ideas here are great — the provider model-fetch and the quieter question-notebook lookup. We've implemented both: a POST /settings/fetch-models endpoint (reusing the existing factory.fetch_models) and a missing_ok 204 path so not-yet-saved questions stop generating 404 noise. Closing this PR in favour of that implementation. Thanks again for the well-scoped contribution! |
pancacake
added a commit
that referenced
this pull request
May 27, 2026
Security: lock down the TutorBot tool sandbox (shell exec is opt-in, all filesystem/shell access confined to the bot workspace) and isolate per-user resources, closing #518, #517, #516, #515, #514 and #506 (first hardened in #507). Bug fixes: chat input disabled after the first turn (#520), KB embedding failure on long documents (#521 / #509), profile creation under Docker (#512 / #513), Qwen reasoning models failing native tool calling (#527 / #528), the GPT-5 init-wizard token parameter (#508), and oversized session-event truncation (#524). Features: HTTP/SSE API for multi-turn chat with a specific TutorBot (#511), multimodal image fallback for vision-capable providers without a capability entry, safe ZIP knowledge upload, and a /settings/network page with model fetching (community PRs #522 and #523 reimplemented locally). Also bumps __version__ to 1.4.1, adds the v1.4.1 release notes, updates the README Releases section, and ships the Astro + Starlight docs site under site/. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the settings model selection flow and reduces noisy question notebook lookup requests.
Changes include:
missing_ok=truesupport for question notebook lookup so unsaved quiz questions can return empty results silently.Related Issues
Module(s) Affected
apiwebsettingstestsi18n/localesTesting
python -m compileall deeptutor testsnpm run build204for missing entries whenmissing_ok=trueNotes
The PR does not include local workspace files or generated temporary files.