Fix fallout from upstream libexpat library rename.#709
Merged
Hoikas merged 1 commit intoH-uru:masterfrom Aug 27, 2020
Merged
Conversation
zrax
reviewed
Aug 26, 2020
As of libexpat 2.2.8, the library was renamed from libexpat to expat. In 2.2.9, this was supposedly reverted back to libexpat; however, in practice, I find that vcpkg builds libexpatMD. Therefore, we now use libexpat's config. However, this is not present in the most recent devlibs bundle with expat 2.2.7, so we fall back on the out of date cmake find module in that case.
zrax
approved these changes
Aug 27, 2020
Hoikas
added a commit
to Hoikas/Plasma
that referenced
this pull request
Aug 30, 2020
This reverts commit 732ad9f, reversing changes made to fde27d9. The bug fixed by H-uru#709 was fixed by microsoft/vcpkg#13022. The upstream fix renamed the target `expat::libexpat` to `expat::expat` but also fixed the expat finder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of libexpat 2.2.8, the library was renamed from libexpat to expat. In 2.2.9, this was supposedly reverted back to libexpat; however, in practice, I find that vcpkg builds libexpatMD. Therefore, we now use libexpat's config. However, this is not present in the most recent devlibs bundle with expat 2.2.7, so we fall back on the out of date cmake find module in that case.
This should fix the latest CI failure in #702.