Merged
Conversation
Hoikas
approved these changes
Aug 21, 2020
Member
|
I RDP'd into an AppVeyor instance that was failing to build zlib, but I couldn't figure out what exactly the problem was. So, I opened microsoft/vcpkg#13105. Maybe one of their pkgconfig people can figure it out. |
The vcpkg cache contains old, stale versions of several packages, which do not get updated automatically by vcpkg install. This ensures they get updated before installing new packages.
This works around issues with vcpkg's implementation of paths, resulting in failures in vcpkg_fixup_pkgconfig when installing zlib.
Member
|
Now we are trying to link the release client against debug libopus 😞 |
This is needed because CMake is picking the debug opus library instead of the release library, causing linking errors when it tries to use debug CRT symbols in release builds.
Member
|
Ugh, MSYS2 broke between the first and second build configuration. sigh |
This reverts commit 732ad9f, reversing changes made to fde27d9. The bug fixed by H-uru#709 was fixed by microsoft/vcpkg#13022. The upstream fix renamed the target `expat::libexpat` to `expat::expat` but also fixed the expat finder.
Member
|
@zrax I've fixed all the weird failures -- are these changes OK? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Moved from #701 due to being in the wrong fork and thus duplicating builds)
The vcpkg cache contains old, stale versions of several packages, which do not get updated automatically by vcpkg install. This ensures they get updated before installing new packages.
This now also removes the old manually-created x86-windows-static-dyncrt triplet in favor of the upstream-supported x86-windows-static-md triplet.