fix: Add height CSS for Safari not showing layer icons (#6394)#6424
Merged
artf merged 2 commits intoGrapesJS:devfrom Mar 5, 2025
Merged
Conversation
artf
approved these changes
Mar 5, 2025
Member
|
Awesome, thank you @sirbeagle 🙇♂️ |
sirbeagle
added a commit
to sirbeagle/grapesjs
that referenced
this pull request
Mar 5, 2025
GrapesJS#6424) * Add height CSS for Safari not showing layer icons (GrapesJS#6394) * Missed the drag icon --------- Co-authored-by: Chris Benjamin <cbenjamin@stormseed.com>
artf
added a commit
that referenced
this pull request
Mar 10, 2025
* Remove the use of @import statements in sass files and remove nested calls that assume a parent style is available and instead reference shared parent items with @use * Update @uses with single quotes per Prettier * fix: Add height CSS for Safari not showing layer icons (#6394) (#6424) * Add height CSS for Safari not showing layer icons (#6394) * Missed the drag icon --------- Co-authored-by: Chris Benjamin <cbenjamin@stormseed.com> * Add options for zoom change event (#6429) * change order uses to match existing files * couple of fixes to incorrect SASS references --------- Co-authored-by: Chris Benjamin <cbenjamin@stormseed.com> Co-authored-by: Artur Arseniev <artur.catch@hotmail.it>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confirmed that layer icons were not showing up in Safari (v18.3). Safari was not matching the set width that was already defined like Chrome and Firefox were. The easiest thing to do here is to just set the height at the same size as the width for the icons - it fixes Safari and doesn't change the computer sizes in the other browsers.
There probably isn't any point in a unit test for this as we wouldn't easily be able to test in a specific browser anyways.
As a side note, I say a deprecation warning for the use of
@importstatements in Sass:I'll take a look to see how difficult it would be to fix that.
Closes #6394.