Remove deprecated @import commands from SASS files#6426
Conversation
…calls that assume a parent style is available and instead reference shared parent items with @use
GrapesJS#6424) * Add height CSS for Safari not showing layer icons (GrapesJS#6394) * Missed the drag icon --------- Co-authored-by: Chris Benjamin <cbenjamin@stormseed.com>
|
I have built the compiled CSS files both with the existing
As far as I can tell this doesn't affect the styles at all, and it only is happening when multiple selectors are defined like above. I'm still checking everything over but I think this might be ready to go shortly. |
|
I have gotten the output |
artf
left a comment
There was a problem hiding this comment.
Checked locally and looks all good, awesome work 👏
This PR is to address the deprecation of the
@importin the SASS processor we are using - details are here.The idea here is to remove the use of
@importstatements in sass files and remove nested calls that assume a parent style is available and instead reference shared parent items with@use.I used the sass-migrator tool as a starting point and then did a bunch of refactoring of how the files are being called. I did break some items into new files (
gjs_main_mixins.scss,gjs_category_general.scss, etc) so that other_gjsfiles could@usethem to do things like extending a style.While I did move stuff around a bit, I did my best not to touch the content or order of styles unless if was absolutely necessary. Obviously these changes touch a core component of the library so we'll need to test the heck out of it if we decide to proceed.