Learn more helper dialog for background fit#854
Merged
Conversation
Contributor
|
Size Change: +793 B (0%) Total Size: 503 kB
ℹ️ View Unchanged
|
swissspidy
reviewed
Mar 30, 2020
assets/src/edit-story/components/panels/backgroundDisplay/dialogContent.js
Outdated
Show resolved
Hide resolved
swissspidy
reviewed
Mar 30, 2020
assets/src/edit-story/components/panels/backgroundDisplay/dialogContent.js
Outdated
Show resolved
Hide resolved
swissspidy
reviewed
Mar 30, 2020
assets/src/edit-story/components/panels/backgroundDisplay/dialogContent.js
Outdated
Show resolved
Hide resolved
swissspidy
approved these changes
Mar 30, 2020
Collaborator
swissspidy
left a comment
There was a problem hiding this comment.
Some nits, otherwise looks good.
Collaborator
|
Just realized it's the renaming of |
Contributor
Author
|
Fixed and rebased :)) |
obetomuniz
added a commit
that referenced
this pull request
Apr 1, 2020
* master: (43 commits) Bump @storybook/react from 5.3.17 to 5.3.18 (#902) Bump @storybook/addon-backgrounds from 5.3.17 to 5.3.18 (#903) updating import path for typeahead menu options Bump @storybook/addon-knobs from 5.3.17 to 5.3.18 (#899) Bump lint-staged from 10.1.0 to 10.1.1 (#898) Bump @storybook/addon-docs from 5.3.17 to 5.3.18 (#896) Bump @testing-library/dom from 7.1.4 to 7.2.0 (#890) Bump eslint-plugin-testing-library from 3.0.0 to 3.0.1 (#887) Fix drop targets on background element + disable opacity for backgrounds (#885) Enables snap to common element distances and removes workaround (#884) Shape previews in the layers panel (#853) [ImgBot] Optimize images Learn more helper dialog for background fit (#854) Restore defaultBackground migration fix output test for font-size minor lints New aspect ratio 2:3 Fix: run the default-background migration (#880) Fixes background element selection (#847) Bump browserslist from 4.11.0 to 4.11.1 ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #251
Changes