Skip to content

Fix background element selection#847

Merged
wassgha merged 1 commit intomasterfrom
fix/nits
Mar 30, 2020
Merged

Fix background element selection#847
wassgha merged 1 commit intomasterfrom
fix/nits

Conversation

@wassgha
Copy link
Copy Markdown
Contributor

@wassgha wassgha commented Mar 29, 2020

Closes #842

Changes

  • Fixes a bug that prevented the background element from getting selected sometimes due to an event conflict with the lasso selector

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 29, 2020

Size Change: +61 B (0%)

Total Size: 499 kB

Filename Size Change
assets/js/edit-story.js 429 kB +61 B (0%)
ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 3.01 kB 0 B
assets/css/stories-dashboard.css 206 B 0 B
assets/js/stories-dashboard.js 66.4 kB 0 B

compressed-size-action

@swissspidy swissspidy added the Type: Bug Something isn't working label Mar 30, 2020
@wassgha wassgha merged commit 0b8d99f into master Mar 30, 2020
@wassgha wassgha deleted the fix/nits branch March 30, 2020 22:32
obetomuniz added a commit that referenced this pull request Apr 1, 2020
* master: (43 commits)
  Bump @storybook/react from 5.3.17 to 5.3.18 (#902)
  Bump @storybook/addon-backgrounds from 5.3.17 to 5.3.18 (#903)
  updating import path for typeahead menu options
  Bump @storybook/addon-knobs from 5.3.17 to 5.3.18 (#899)
  Bump lint-staged from 10.1.0 to 10.1.1 (#898)
  Bump @storybook/addon-docs from 5.3.17 to 5.3.18 (#896)
  Bump @testing-library/dom from 7.1.4 to 7.2.0 (#890)
  Bump eslint-plugin-testing-library from 3.0.0 to 3.0.1 (#887)
  Fix drop targets on background element + disable opacity for backgrounds (#885)
  Enables snap to common element distances and removes workaround (#884)
  Shape previews in the layers panel (#853)
  [ImgBot] Optimize images
  Learn more helper dialog for background fit (#854)
  Restore defaultBackground migration
  fix output test for font-size
  minor lints
  New aspect ratio 2:3
  Fix: run the default-background migration (#880)
  Fixes background element selection (#847)
  Bump browserslist from 4.11.0 to 4.11.1
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Background - Enter Edit Mode

4 participants