Reduce timing difference for entering text edit mode.#829
Merged
Conversation
Contributor
|
Size Change: 0 B Total Size: 498 kB ℹ️ View Unchanged
|
barklund
approved these changes
Mar 27, 2020
obetomuniz
added a commit
that referenced
this pull request
Mar 30, 2020
* master: Update list of Google Fonts Bump babel-jest from 25.2.3 to 25.2.4 (#851) Resize video while resizing (#804) Bump @wordpress/components from 9.2.5 to 9.2.6 (#839) Bump eslint-plugin-testing-library from 2.2.3 to 3.0.0 (#849) Bump react-moveable from 0.18.1 to 0.19.0 (#850) Bump lint-staged from 10.0.9 to 10.0.10 Bump eslint-plugin-import from 2.20.1 to 2.20.2 (#846) Auto-select entire input field on focus (#811) Disallow masking for background. (#827) Reduce timing difference for entering edit mode. (#829) Clicking on media in the gallery should never insert as background (#841) Bump @testing-library/dom from 7.1.2 to 7.1.3 (#843) Reorderable drag and drop component (#709) Minimize layer panel height + fixes for expanding/collapsing (#704) remove lingering extra styled component import comment adding tests for which icon is present on chip bookmark some clean up bookmark chip ui component. 2 sizes controlled by constants.js. Storybook + a very basic test Template Animations: Added float-on animation (#618)
Collaborator
|
Added to alpha branch |
swissspidy
pushed a commit
that referenced
this pull request
Mar 30, 2020
dvoytenko
reviewed
Mar 30, 2020
| const timingDifference = window.performance.now() - clickTime; | ||
|
|
||
| if (timingDifference > 300) { | ||
| if (timingDifference > 150) { |
Contributor
There was a problem hiding this comment.
150ms is a VERY short click. It was increased to 300ms due to a reported bug that it was too small. I think our problem is more related to the "drag" than speed of click. The coordinates have moved too far and that could be a better indicator.
Contributor
Author
There was a problem hiding this comment.
Hmm, interesting.
When I was testing then the number was mostly under 10 actually, when clicking and holding down (for a moment) then around 100.
However, might be just how it is for me locally. Will reopen the issue then to investigate more.
Contributor
There was a problem hiding this comment.
I think it has a lot to do with the type of pointer: mouse vs touchpad vs touch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #729
Reduces timing difference to stop entering edit mode when dragging.
In my testing, even a bit slower than normal click almost never exceeded 150, however, very short dragging was around 250.
Changed the value to 150 which seems to be short enough not to trigger when dragging but long enough even for a bit "slower" click.