Conversation
Contributor
|
Size Change: +222 B (0%) Total Size: 499 kB
ℹ️ View Unchanged
|
swissspidy
reviewed
Mar 23, 2020
Contributor
Author
|
Up to @barklund |
barklund
reviewed
Mar 24, 2020
| <Panel name="layers" initialHeight={DEFAULT_LAYERS_VISIBLE * LAYER_HEIGHT}> | ||
| <Panel | ||
| name="layers" | ||
| initialHeight={(layers?.length || DEFAULT_LAYERS_VISIBLE) * LAYER_HEIGHT} |
Contributor
There was a problem hiding this comment.
Is this aligned with @samitron7? The design originally called for always 6 initial rows. We have #227 too, by the way, which is then fixed by this issue?
Contributor
Author
There was a problem hiding this comment.
Tagging @samitron7 here but from our discussion it seemed like she wanted it to vary by number of items more than page size
This was referenced Mar 26, 2020
obetomuniz
added a commit
that referenced
this pull request
Mar 30, 2020
* master: Update list of Google Fonts Bump babel-jest from 25.2.3 to 25.2.4 (#851) Resize video while resizing (#804) Bump @wordpress/components from 9.2.5 to 9.2.6 (#839) Bump eslint-plugin-testing-library from 2.2.3 to 3.0.0 (#849) Bump react-moveable from 0.18.1 to 0.19.0 (#850) Bump lint-staged from 10.0.9 to 10.0.10 Bump eslint-plugin-import from 2.20.1 to 2.20.2 (#846) Auto-select entire input field on focus (#811) Disallow masking for background. (#827) Reduce timing difference for entering edit mode. (#829) Clicking on media in the gallery should never insert as background (#841) Bump @testing-library/dom from 7.1.2 to 7.1.3 (#843) Reorderable drag and drop component (#709) Minimize layer panel height + fixes for expanding/collapsing (#704) remove lingering extra styled component import comment adding tests for which icon is present on chip bookmark some clean up bookmark chip ui component. 2 sizes controlled by constants.js. Storybook + a very basic test Template Animations: Added float-on animation (#618)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #764
Partial to #746
Partial to #332
Partial to #517
This refactors/rethinks the layer re-ordering component into three generic components:
<Reorderable>(a container of sortable elements),<ReorderableSeparator>and<ReorderableItem>. The refactor is currently only used in the layers panel, in a second PR it will be used for theGridViewand the carousel thumbnails in order to deprecate the currentDropZonecomponent./cc @dvoytenko @barklund