Skip to content

(gke) Remove additional network settings from TPU v6e,7x and g4#5692

Merged
agrawalkhushi18 merged 1 commit into
GoogleCloudPlatform:developfrom
agrawalkhushi18:add-net-tpu
May 21, 2026
Merged

(gke) Remove additional network settings from TPU v6e,7x and g4#5692
agrawalkhushi18 merged 1 commit into
GoogleCloudPlatform:developfrom
agrawalkhushi18:add-net-tpu

Conversation

@agrawalkhushi18

@agrawalkhushi18 agrawalkhushi18 commented May 20, 2026

Copy link
Copy Markdown
Contributor

This PR eliminates additional network configuration in the GKE TPU v6e, 7x and G4 examples. This is a follow up item referencing PR#5652

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@agrawalkhushi18 agrawalkhushi18 added the release-improvements Added to release notes under the "Improvements" heading. label May 20, 2026
@gemini-code-assist

gemini-code-assist Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the network configuration within several Google Kubernetes Engine (GKE) example deployments, specifically for G4, TPU v6e, and TPU 7x clusters. The change aims to simplify the YAML definitions by abstracting the detailed additional_networks settings into a reusable variable, improving readability and consistency across these examples. This is a follow-up to a previous PR, ensuring a more standardized approach to network setup.

Highlights

  • Network Configuration Simplification: The explicit additional_networks configuration blocks have been removed from GKE G4, TPU v6e, and TPU 7x example YAML files. These verbose definitions were replaced with a concise reference to $(<network_resource_name>.instance_additional_networks), streamlining the network setup.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 20, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the additional_networks configuration across GKE G4, TPU v7x, and TPU v6e blueprints to use module outputs. Feedback suggests that for these machine types, explicitly defining additional_networks in the node pool disables automatic DRANET (Dynamic Resource Allocation for Networking). To properly enable DRANET and maintain blueprint consistency, the reviewer recommends removing the additional_networks setting from the node pool modules entirely and reverting to the standard $(concat(...)) syntax within the cluster modules.

Comment thread examples/gke-g4/gke-g4.yaml
Comment thread examples/gke-tpu-7x/gke-tpu-7x-advanced.yaml
Comment thread examples/gke-tpu-v6e/gke-tpu-v6e-advanced.yaml
Comment thread examples/gke-tpu-v6e/gke-tpu-v6e.yaml
@agrawalkhushi18 agrawalkhushi18 marked this pull request as ready for review May 21, 2026 05:33
@agrawalkhushi18 agrawalkhushi18 requested a review from a team as a code owner May 21, 2026 05:33
SwarnaBharathiMantena
SwarnaBharathiMantena approved these changes May 21, 2026
View reviewed changes

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agrawalkhushi18 agrawalkhushi18 merged commit 3ab92bd into GoogleCloudPlatform:develop May 21, 2026
24 of 90 checks passed
kadupoornima pushed a commit to kadupoornima/cluster-toolkit that referenced this pull request May 25, 2026
@agrawalkhushi18 @kadupoornima
(gke) Remove additional network settings from TPU v6e,7x and g4 (Goog…
b2bf11f 
…leCloudPlatform#5692)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@agrawalkhushi18 @SwarnaBharathiMantena