Skip to content

(gke) Remove additional network settings from A3U blueprint#5652

Merged
agrawalkhushi18 merged 3 commits into
GoogleCloudPlatform:developfrom
agrawalkhushi18:additional_network
May 19, 2026
Merged

(gke) Remove additional network settings from A3U blueprint#5652
agrawalkhushi18 merged 3 commits into
GoogleCloudPlatform:developfrom
agrawalkhushi18:additional_network

Conversation

@agrawalkhushi18

@agrawalkhushi18 agrawalkhushi18 commented May 12, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR modifies GKE network configuration in blueprint to use VPC module output. It simplifies additional_networks configuration by leveraging vpc module output, eliminating duplicate network configuration boilerplate.

Changes

  • Replaces hardcoded network interface specifications in gke-cluster and gke-node-pool module with a reusable additional_networks output from the VPC module
  • Eliminates duplicate network configuration in the GKE A3 Ultra GPU example
  • Makes the configuration more maintainable and DRY

Benefits

  • Reduces code duplication across examples
  • Makes future updates to network configuration easier to manage
  • Centralizes network interface defaults in the VPC module, and makes it consistent across multi-vpc and rdma-net

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@agrawalkhushi18 agrawalkhushi18 added the release-chore To not include into release notes label May 12, 2026
@gemini-code-assist

gemini-code-assist Bot commented May 12, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the maintainability of GKE network configurations by abstracting common network interface settings into the VPC module. By providing a standardized additional_networks output, the changes eliminate redundant hardcoded configurations across deployment examples, ensuring consistency and simplifying future network updates.

Highlights

  • Network Configuration Refactoring: Centralized network interface definitions by introducing an additional_networks output in the VPC module, reducing boilerplate in GKE configurations.
  • Example Simplification: Updated the GKE A3 Ultra GPU example to leverage the new VPC module output, resulting in cleaner and more maintainable YAML configurations.
  • Documentation Update: Updated the VPC module README to include the new additional_networks output in the documentation table.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 12, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the gke-a3-ultragpu example to use a new additional_networks output from the VPC module, reducing configuration duplication. The VPC module now includes a local definition and an output for a GKE-compatible network interface configuration representing the primary subnetwork. Review feedback recommends enhancing the robustness of this new output by dynamically setting the stack_type to support dual-stack VPCs and improving documentation clarity to specify that the output describes the primary subnetwork.

Comment thread modules/network/vpc/main.tf Outdated
Comment thread modules/network/vpc/outputs.tf
Comment thread modules/network/vpc/README.md
@agrawalkhushi18 agrawalkhushi18 marked this pull request as ready for review May 13, 2026 05:48
@agrawalkhushi18 agrawalkhushi18 requested a review from a team as a code owner May 13, 2026 05:48
SwarnaBharathiMantena
SwarnaBharathiMantena approved these changes May 19, 2026
View reviewed changes

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agrawalkhushi18 agrawalkhushi18 merged commit 914fb97 into GoogleCloudPlatform:develop May 19, 2026
14 of 79 checks passed
This was referenced May 20, 2026
Merged
Merged
@agrawalkhushi18 agrawalkhushi18 added release-improvements Added to release notes under the "Improvements" heading. and removed release-chore To not include into release notes labels May 20, 2026
kadupoornima pushed a commit to kadupoornima/cluster-toolkit that referenced this pull request May 25, 2026
@agrawalkhushi18 @kadupoornima
(gke) Remove additional network settings from A3U blueprint (GoogleCl…
a0bbc59 
…oudPlatform#5652)
This was referenced Jun 4, 2026
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@agrawalkhushi18 @SwarnaBharathiMantena