Skip to content

(gke) Remove additional networks from A4 nd A4X family blueprints#5682

Merged
agrawalkhushi18 merged 2 commits into
GoogleCloudPlatform:developfrom
agrawalkhushi18:a4-networks
May 21, 2026
Merged

(gke) Remove additional networks from A4 nd A4X family blueprints#5682
agrawalkhushi18 merged 2 commits into
GoogleCloudPlatform:developfrom
agrawalkhushi18:a4-networks

Conversation

@agrawalkhushi18

@agrawalkhushi18 agrawalkhushi18 commented May 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR eliminates additional network configuration in the GKE A4, A4X and A4X-Max-BM examples. This is a follow up item after PR#5652

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@gemini-code-assist

gemini-code-assist Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the network configuration for GKE a4 and a4x blueprints by replacing manual, hardcoded network interface definitions with dynamic references. This change simplifies the configuration management and ensures consistency across the deployment groups by leveraging existing network properties instead of explicitly defining them in the YAML files.

Highlights

  • Network Configuration Cleanup: Removed hardcoded network interface definitions from GKE blueprints for a4 and a4x families in favor of using dynamic additional_networks references.
  • NIC Type Update: Added explicit IDPF NIC type configuration to the gke-a4x-max-bm blueprint to ensure proper network interface handling.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 19, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies GKE blueprint configurations by refactoring additional_networks to use module outputs and adds nic_type: "IDPF" to the gke-a4x-max-bm example. Review feedback emphasizes that for bare-metal machine types, additional_networks must be configured on the node pool rather than the GKE cluster to ensure correct physical NIC attachment for DRA drivers. Additionally, the reviewer notes that nic_type (such as GVNIC) should be explicitly defined in the network module settings to prevent deployment failures and maintain consistency with established H4D blueprint patterns.

Comment thread examples/gke-a4/gke-a4.yaml Outdated
Comment thread examples/gke-a4/gke-a4.yaml Outdated
Comment thread examples/gke-a4x/gke-a4x.yaml Outdated
Comment thread examples/gke-a4x/gke-a4x.yaml Outdated
@agrawalkhushi18 agrawalkhushi18 changed the title (gke) Remove additional networks from a4 nd a4x family blueprints (gke) Remove additional networks from A4 nd A4x family blueprints May 20, 2026
@agrawalkhushi18 agrawalkhushi18 added the release-improvements Added to release notes under the "Improvements" heading. label May 20, 2026
@agrawalkhushi18 agrawalkhushi18 changed the title (gke) Remove additional networks from A4 nd A4x family blueprints (gke) Remove additional networks from A4 nd A4X family blueprints May 20, 2026
@agrawalkhushi18 agrawalkhushi18 marked this pull request as ready for review May 21, 2026 05:33
@agrawalkhushi18 agrawalkhushi18 requested a review from a team as a code owner May 21, 2026 05:33
SwarnaBharathiMantena
SwarnaBharathiMantena approved these changes May 21, 2026
View reviewed changes

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agrawalkhushi18 agrawalkhushi18 merged commit f7bf6d0 into GoogleCloudPlatform:develop May 21, 2026
26 of 98 checks passed
kadupoornima pushed a commit to kadupoornima/cluster-toolkit that referenced this pull request May 25, 2026
@agrawalkhushi18 @kadupoornima
(gke) Remove additional networks from A4 nd A4X family blueprints (Go…
4ad5783 
…ogleCloudPlatform#5682)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@agrawalkhushi18 @SwarnaBharathiMantena