Skip to content

Documentation changes related to CentOS 7 and PBS Pro within the cluster-toolkit repository.#4792

Merged
sudheer-quad merged 10 commits intoGoogleCloudPlatform:developfrom
siddhartha-quad:updated-docs
Jan 13, 2026
Merged

Documentation changes related to CentOS 7 and PBS Pro within the cluster-toolkit repository.#4792
sudheer-quad merged 10 commits intoGoogleCloudPlatform:developfrom
siddhartha-quad:updated-docs

Conversation

@siddhartha-quad
Copy link
Contributor

@siddhartha-quad siddhartha-quad commented Oct 27, 2025 •
edited
Loading

This PR removes outdated documentation related to CentOS 7, PBS Pro, and DDN-EXAScaler within the cluster-toolkit repository. Several files were identified as needing updates, including network_storage.md, gpu-support.md, and vm-images.md.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@siddhartha-quad
Update gpu-support.md
d5dbad3
@siddhartha-quad
Update network_storage.md
9ebc181 
Removed DDN-EXAScaler reference
@siddhartha-quad
Update vm-images.md
bb5cf43 
updated OS Version
@siddhartha-quad
Update README.md
5506661 
removed DDN-EXAScaler reference
@siddhartha-quad
Update README.md
c53740e 
Removed DDN-EXAScaler reference
@siddhartha-quad siddhartha-quad requested review from a team and samskillman as code owners October 27, 2025 10:09
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Oct 27, 2025

Summary of Changes

Hello @siddhartha-quad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on maintaining the accuracy and relevance of the project's documentation. It primarily removes outdated references to the deprecated DDN EXAScaler Lustre file system across various documentation and example files. Additionally, it updates an example VM image configuration and refines the list of modules supporting GPU accelerator automation.

Highlights

  • Documentation Cleanup for DDN EXAScaler Lustre: All references to the deprecated DDN EXAScaler Lustre file system have been removed from the network_storage.md, examples/README.md, and modules/README.md files, streamlining the documentation.
  • VM Image Example Update: The example configuration for instance_image in docs/vm-images.md has been updated to use hpc-rocky-linux-8 from the cloud-hpc-image-public project.
  • GPU Support Documentation Refinement: The docs/gpu-support.md file was updated to remove "and PBS Pro" from the list of modules that support guest_accelerator config automation, ensuring accuracy.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@siddhartha-quad siddhartha-quad added the release-chore To not include into release notes label Oct 27, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 27, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes references to the deprecated DDN-EXA-Scaler module from the documentation. The changes are mostly correct and align with the PR's goal. I've left a couple of comments on minor issues in the documentation that arose from the removals, which leave some sections in a confusing state. Additionally, I noticed a few changes unrelated to the DDN-EXA-Scaler removal. While these may be valid, it's best practice to keep pull requests focused on a single logical change for easier review.

cboneti
cboneti previously requested changes Nov 6, 2025
View reviewed changes
Copy link
Member

@cboneti cboneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.

Let's make sure #4790 merges before we review / move forward with this one.

Furthermore, please create a better PR description (title and text) as this is a more general documentation update beyond DDN Exascaler...

@siddhartha-quad siddhartha-quad changed the title Updated docs(Removed DDN-EXA-Scaler reference) Documentation changes related to CentOS 7, PBS Pro, and DDN-EXAScaler within the cluster-toolkit repository. Jan 13, 2026
@siddhartha-quad siddhartha-quad changed the title Documentation changes related to CentOS 7, PBS Pro, and DDN-EXAScaler within the cluster-toolkit repository. Documentation changes related to CentOS 7 and PBS Pro within the cluster-toolkit repository. Jan 13, 2026
Neelabh94
Neelabh94 requested changes Jan 13, 2026
View reviewed changes
@sudheer-quad sudheer-quad force-pushed the updated-docs branch 4 times, most recently from 37e2c94 to 81cbdd4 Compare January 13, 2026 11:20
Neelabh94
Neelabh94 previously approved these changes Jan 13, 2026
View reviewed changes
@sudheer-quad sudheer-quad dismissed cboneti’s stale review January 13, 2026 11:44

The requested changes have been updated and are now awaiting approval from another available engineer.

@sudheer-quad sudheer-quad merged commit 37e8cac into GoogleCloudPlatform:develop Jan 13, 2026
11 of 79 checks passed
kvenkatachala333 pushed a commit to kvenkatachala333/cluster-toolkit that referenced this pull request Jan 28, 2026
@siddhartha-quad @sudheer-quad @kvenkatachala333
Documentation changes related to CentOS 7 and PBS Pro within the clus…
aa76b0d 
…ter-toolkit repository. (GoogleCloudPlatform#4792)

Co-authored-by: Sudheer <markapurams@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Neelabh94 Neelabh94 Neelabh94 approved these changes

@agrawalkhushi18 agrawalkhushi18 agrawalkhushi18 approved these changes

@samskillman samskillman Awaiting requested review from samskillman samskillman is a code owner

@cboneti cboneti Awaiting requested review from cboneti

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@siddhartha-quad @cboneti @Neelabh94 @agrawalkhushi18 @sudheer-quad