Skip to content

Delete ddn-exascaler filesystem module reference blueprints#4790

Merged
sudheer-quad merged 12 commits intoGoogleCloudPlatform:developfrom
sudheer-quad:DDN-EXAScaler_deletion
Jan 13, 2026
Merged

Delete ddn-exascaler filesystem module reference blueprints#4790
sudheer-quad merged 12 commits intoGoogleCloudPlatform:developfrom
sudheer-quad:DDN-EXAScaler_deletion

Conversation

@sudheer-quad
Copy link
Contributor

@sudheer-quad sudheer-quad commented Oct 27, 2025 •
edited
Loading

This PR replaces all references and implementations of DDN EXAscaler with Managed Lustre across the repository. It also updates the toolkit versioning to ensure compatibility with the new Managed Lustre features.

  1. Removed all legacy references to DDN EXAScaler across the repository.
  2. Replaced the DDN EXAscaler file system with Managed Lustre within the hpc-enterprise-slurm blueprint.
  3. Removed lustre-vm and lustre-slurm blueprints from the repository.
  4. Integrated test validation for both the managed-lustre-vm and managed-lustre-slurm blueprints.
  5. Bumped toolkit version from v1.38.0 to v1.49.0 in versioned blueprint YAML file to ensure compatibility with the Managed Lustre support introduced in the later version.
  6. Cleaned up the htc-slurm blueprint by removing the projects-fs and lustrefs file systems.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@sudheer-quad sudheer-quad requested review from a team and samskillman as code owners October 27, 2025 06:36
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Oct 27, 2025

Summary of Changes

Hello @sudheer-quad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on removing the deprecated DDN EXAScaler filesystem module and all its associated components from the repository. The removal encompasses the module's core Terraform files, documentation, and all related testing and deployment blueprints and configurations. This change is a direct consequence of the module's deprecation, aiming to simplify the project structure and eliminate unsupported elements, guiding users towards actively maintained solutions.

Highlights

  • DDN EXAScaler Module Removal: The entire community/modules/file-system/DDN-EXAScaler module, including its Terraform configurations, variables, outputs, and documentation, has been removed from the repository. This action aligns with the module's deprecation notice, which indicated its planned removal by July 1, 2025.
  • Associated Test Infrastructure Deleted: All related test infrastructure for the DDN EXAScaler module has been deleted. This includes Ansible playbooks for Lustre testing with Slurm and VMs, as well as Cloud Build blueprints and test configurations that referenced the deprecated module.
  • Codebase Streamlining: This cleanup streamlines the codebase by removing an unsupported and deprecated file system module, reducing maintenance overhead and focusing resources on recommended alternatives like the GCP Managed Lustre module.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 27, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the deprecated DDN-EXAScaler filesystem module, along with its associated documentation, Terraform code, and test files. This is a good step towards cleaning up the codebase.

However, the removal appears to be incomplete. I've found several lingering references to the DDN-EXAScaler module in files that were not modified in this pull request. Leaving these references will lead to broken links and potentially failing deployments for users who try to use examples that reference the deleted module.

Please update the following files to remove all references to DDN-EXAScaler:

  • docs/network_storage.md: This file still contains links and compatibility information for the DDN-EXAScaler module.
  • examples/hpc-enterprise-slurm.yaml: This example blueprint still attempts to use the community/modules/file-system/DDN-EXAScaler module.

Addressing these dangling references is critical to ensure a clean removal of the deprecated module.

@aslam-quad
Copy link
Contributor

aslam-quad commented Oct 27, 2025

/gcbrun

@aslam-quad aslam-quad added the release-chore To not include into release notes label Oct 27, 2025
@aslam-quad
Copy link
Contributor

aslam-quad commented Oct 27, 2025

/gcbrun

@cboneti cboneti self-assigned this Oct 28, 2025
cboneti
cboneti requested changes Oct 28, 2025
View reviewed changes
Copy link
Member

@cboneti cboneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left several comments, but not in every test file.
Directionally, I would like us to assess when we should replace ddn exascaler for managed lustre, versus removing the example. Furthermore, the testing coverage of managed lustre must be the same or superior to the unmanaged version. Please review the tests.

cboneti
cboneti reviewed Oct 30, 2025
View reviewed changes
Copy link
Member

@cboneti cboneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few new comments.

@cboneti cboneti assigned sudheer-quad and unassigned cboneti Oct 30, 2025
@sudheer-quad sudheer-quad force-pushed the DDN-EXAScaler_deletion branch from 0384682 to 82be1fb Compare October 31, 2025 05:14
@cboneti
Copy link
Member

cboneti commented Oct 31, 2025

Please feel free to reassign this PR to me when you feel it is ready to review again.

@aslam-quad
Copy link
Contributor

aslam-quad commented Oct 31, 2025

/gcbrun

cboneti
cboneti requested changes Nov 6, 2025
View reviewed changes
Copy link
Member

@cboneti cboneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done another round of reviews, resolved old comments and add a few new comments, PTAL.

@cboneti cboneti mentioned this pull request Nov 6, 2025
Merged
@kadupoornima
Copy link
Contributor

kadupoornima commented Nov 11, 2025

/gcbrun

@sudheer-quad sudheer-quad force-pushed the DDN-EXAScaler_deletion branch from 82eb6c7 to 79f2067 Compare November 11, 2025 08:20
cboneti
cboneti reviewed Nov 12, 2025
View reviewed changes
vikramvs-gg
vikramvs-gg reviewed Nov 24, 2025
View reviewed changes
@vikramvs-gg
Copy link
Contributor

vikramvs-gg commented Nov 24, 2025

Please remove the reference of DDN EXAScaler from the docs/network_storage.md. This file still contains links and compatibility information for the DDN-EXAScaler module.

@aslam-quad
Copy link
Contributor

aslam-quad commented Dec 10, 2025

/gcbrun

@sudheer-quad sudheer-quad force-pushed the DDN-EXAScaler_deletion branch from 249411e to ebf3f88 Compare December 10, 2025 13:30
@aslam-quad
Copy link
Contributor

aslam-quad commented Dec 10, 2025

/gcbrun

@sudheer-quad sudheer-quad force-pushed the DDN-EXAScaler_deletion branch from ebf3f88 to e2c887d Compare December 30, 2025 10:36
@sudheer-quad sudheer-quad force-pushed the DDN-EXAScaler_deletion branch 4 times, most recently from 5eaa3e0 to a6af307 Compare December 30, 2025 12:09
@sarthakag sarthakag mentioned this pull request Jan 2, 2026
Closed
@sudheer-quad sudheer-quad force-pushed the DDN-EXAScaler_deletion branch 2 times, most recently from e814562 to e3e4bc4 Compare January 5, 2026 11:27
@sudheer-quad sudheer-quad force-pushed the DDN-EXAScaler_deletion branch from e3e4bc4 to 7cb76e7 Compare January 5, 2026 12:42
@SwarnaBharathiMantena
Copy link
Contributor

SwarnaBharathiMantena commented Jan 6, 2026

Please also cleanup the modules/README.md file that has info on this module.

@sudheer-quad sudheer-quad force-pushed the DDN-EXAScaler_deletion branch from 02c45d5 to dd169e9 Compare January 8, 2026 06:53
@sudheer-quad sudheer-quad merged commit 889a9fb into GoogleCloudPlatform:develop Jan 13, 2026
80 of 90 checks passed
@sudheer-quad sudheer-quad deleted the DDN-EXAScaler_deletion branch February 3, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarthakag sarthakag sarthakag approved these changes

@cboneti cboneti cboneti approved these changes

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

@parulbajaj01 parulbajaj01 parulbajaj01 approved these changes

@samskillman samskillman Awaiting requested review from samskillman samskillman is a code owner

@vikramvs-gg vikramvs-gg Awaiting requested review from vikramvs-gg

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sudheer-quad sudheer-quad

Labels

release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@sudheer-quad @aslam-quad @cboneti @kadupoornima @vikramvs-gg @SwarnaBharathiMantena @sarthakag @parulbajaj01