Making CloudSQL to use internal IP address instead of external for Slurm Accounting DB.#1795
Merged
Merged
Conversation
Member
|
Eimantas, the PR-validation test is failing. |
cboneti
reviewed
Sep 28, 2023
Collaborator
Author
|
@cboneti I think I fixed the initial issue in pre-build, however it's still failing with |
Member
|
/gcbrun |
The /etc/profile.d login prompt informational message makes the assumption that the VM is running a startup-script that uses our startup-script module. This assumption is broken when an image is built using our startup-script module and then a VM is booted with that image that does not execute our startup-script module. This assumption is also broken upon reboots of Slurm VMs because our script is wrapped inside a startup script solution developed by SchedMD that exits early when Slurm has previously started successfully. We can reconsider enabling this message more robustly as part of future work.
…e_not_yet_started_message Eliminate startup-script hasn't started message
cboneti
approved these changes
Nov 29, 2023
Member
|
/gcbrun |
…atform#2012) (cherry picked from commit 1217af0)
…release-candidate Release v1.26.0
auto-merge was automatically disabled
December 8, 2023 12:21
Head branch was pushed to by a user without write access
* Add rudimentary codespell config
* Add pre-commit definition for codespell
* ot -> it typo fix
* Some more skips for codespell
* [DATALAD RUNCMD] Do interactive fixing of some ambigous typos
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w -i 3 -C 2 ./community/front-end/ofe/script/service_account.sh ./community/front-end/ofe/website/ghpcfe/models.py ./community/front-end/ofe/website/ghpcfe/models.py ./community/modules/scripts/htcondor-install/files/autoscaler.py ./community/modules/scripts/ramble-setup/README.md ./docs/videos/healthcare-and-life-sciences/README.md ./examples/README.md ./tools/validate_configs/test_configs/README.md",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
* 1 more typo fixed manually
* Skip (S)hortcuts, more words and files
* [DATALAD RUNCMD] run codespell throughout fixing typo automagically
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
* Duplicate ignore of requirements.txt and js in pre-commit config
until codespell-project/codespell#3196 is addressed
**NO CODE CHANGES** just moving around.
Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.4 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.4...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.14.0 to 0.15.0. - [Commits](golang/sys@v0.14.0...v0.15.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.151.0 to 0.152.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.151.0...v0.152.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/spf13/afero](https://github.com/spf13/afero) from 1.10.0 to 1.11.0. - [Release notes](https://github.com/spf13/afero/releases) - [Commits](spf13/afero@v1.10.0...v1.11.0) --- updated-dependencies: - dependency-name: github.com/spf13/afero dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.10.0 to 5.10.1. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](go-git/go-git@v5.10.0...v5.10.1) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Legacy metadata to be removed, added comment.
Use older release until we address the code changes required by terraform-linters/tflint-ruleset-terraform#133
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies
community/modules/database/slurm-cloudsql-federationmodule. It makes communication between the Slurm cluster controller node and SQL database over the private network instead of the external. This way SQL instance does not need to have external IP address. It allows for both Slurm cluster and SQL instance to be completely isolated from the external networks.The resulting Slurmdbd configuration made by using this updated module on the test cluster:
Snippet from the test blueprint to demonstrate use case:
- id: slurm-sql source: community/modules/database/slurm-cloudsql-federation kind: terraform use: [network1] settings: sql_instance_name: slurm-sql8-ofe tier: "db-g1-small" - id: slurm_controller source: community/modules/scheduler/schedmd-slurm-gcp-v5-controller use: - network1 - compute_partition - homefs - slurm-sql settings: instance_image: family: slurm-gcp-5-8-hpc-rocky-linux-8 project: schedmd-slurm-public