Enable SSL mode in embedded Cassandra used by unit tests.#2130
Merged
VardhanThigle merged 1 commit intoGoogleCloudPlatform:mainfrom Jan 14, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2130 +/- ##
============================================
+ Coverage 46.62% 54.68% +8.06%
+ Complexity 3953 1574 -2379
============================================
Files 867 401 -466
Lines 51567 21725 -29842
Branches 5399 2156 -3243
============================================
- Hits 24043 11881 -12162
+ Misses 25808 9147 -16661
+ Partials 1716 697 -1019
|
Contributor
|
Could we get a summary as a code comment of why all this is needed to enable SSL as readers may not be fully aware of the nuances of enabling SSL? |
1632f51 to
3b39d1f
Compare
Contributor
Author
|
3b39d1f to
6ed1b5a
Compare
Deep1998
approved these changes
Jan 14, 2025
shreyakhajanchi
approved these changes
Jan 14, 2025
darshan-sj
pushed a commit
that referenced
this pull request
Jan 15, 2025
pawankashyapollion
pushed a commit
to ollionorg/DataflowTemplates-fork
that referenced
this pull request
Jan 15, 2025
akashthawaitcc
pushed a commit
to ollionorg/DataflowTemplates-fork
that referenced
this pull request
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This is a child of #2114.
This has UT only changes to enable SSL in embedded Cassandra used by Bulk UT.