[Draft: Not for review] Changes to use Existing cassandra io for Bulk Cassandra Read with SSL#2114
Closed
VardhanThigle wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
Closed
Conversation
7c79275 to
02378ed
Compare
19833f9 to
bea08e7
Compare
bea08e7 to
33a2032
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2114 +/- ##
============================================
+ Coverage 46.61% 54.97% +8.35%
+ Complexity 4278 1608 -2670
============================================
Files 868 406 -462
Lines 51581 21864 -29717
Branches 5401 2161 -3240
============================================
- Hits 24046 12019 -12027
+ Misses 25815 9147 -16668
+ Partials 1720 698 -1022
|
ad50525 to
4139891
Compare
4139891 to
2e79196
Compare
2e79196 to
36bc67b
Compare
This was referenced Jan 13, 2025
33c1ba0 to
c5a53e4
Compare
c5a53e4 to
eda2d84
Compare
eda2d84 to
dfc3c6f
Compare
Contributor
|
This pull request has been marked as stale due to 180 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time. Thank you for your contributions. |
Contributor
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Changes to use Existing CassandraIO for Cassandra Bulk Read.
Note on Techdept
The existing CassandraIO works with Cassandra Driver's 3.0 interfaces. This would mean that we won't get out of box support for all the new features and configurations that 4.0 driver provides out of box. With this PR we are enabling the most basic use case of reading a primitive types on SSL enabled Cluster with client side validation. Mutual TLS and other advanced options are not implemented currently.
The strategy to eliminate this techdebt is to enable 4.0 in upstream code, once the Cassandra Bulk is working for basic use cases.
Till then, if we see any specific customer use case, we can manually incorporate it (the way SSL is currently handled).
PR Tree:
At the moment the PR is large. To de-risk having a lot of code for review, we have raised 2 child PRs: