Skip to content

1.29 support (Graph API)#41

Merged
Kevman95 merged 5 commits intoGoobwabber:mainfrom
roydejong:dev-1.29.0
Apr 14, 2023
Merged

1.29 support (Graph API)#41
Kevman95 merged 5 commits intoGoobwabber:mainfrom
roydejong:dev-1.29.0

Conversation

@roydejong
Copy link
Copy Markdown
Collaborator

@roydejong roydejong commented Apr 1, 2023 •
edited
Loading

This PR adds support for Beat Saber 1.29 by targeting GameLift API overrides rather than master server overrides, which are now no longer supported:

  • Adds setting and API to override graphUrl from the game's network config with a custom URL
  • Removes MasterServerEndPoint and DisableGameLift patches; rather, if we are overriding Graph URL, we now always force GameLift use
  • Bumps MpCore version to 1.3.0 and target Beat Saber 1.29.0

Cross-dependent related PRs

@roydejong roydejong mentioned this pull request Apr 1, 2023
Merged
@rcelyte
Copy link
Copy Markdown
Contributor

rcelyte commented Apr 1, 2023

I was kind of hoping we could fuse the graph URL and status URL into one web host to simplify configuration 😕 (Official uses a single domain for both as well)

@roydejong
Copy link
Copy Markdown
Collaborator Author

roydejong commented Apr 1, 2023

I was kind of hoping we could fuse the graph URL and status URL into one web host to simplify configuration 😕 (Official uses a single domain for both as well)

I personally think that this adds a bit more flexibility in how server operators want to handle this.

In BT's case, for example, the status API and Graph API will most likely end up on completely different ports, so some granularity in defining that is desirable.

Nothing here is final though - this is just my proposal and is all open to discussion for sure

@roydejong roydejong mentioned this pull request Apr 1, 2023
Merged
@rcelyte
Copy link
Copy Markdown
Contributor

rcelyte commented Apr 3, 2023

Appears to work perfectly on 1.29.0 👍 (testing with UseCustomApiServer("https://master.battletrains.org", "https://master.battletrains.org");)

@roydejong roydejong mentioned this pull request Apr 9, 2023
Merged
@Kevman95
Copy link
Copy Markdown
Collaborator

Kevman95 commented Apr 14, 2023

Merging ;)

@Kevman95 Kevman95 closed this Apr 14, 2023
@Kevman95 Kevman95 reopened this Apr 14, 2023
@Kevman95 Kevman95 merged commit 7838a1e into Goobwabber:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roydejong @rcelyte @Kevman95