Skip to content

1.29 support (Graph API) #42

Merged
Kevman95 merged 4 commits intomasterfrom
dev-1.29
Apr 14, 2023
Merged

1.29 support (Graph API) #42
Kevman95 merged 4 commits intomasterfrom
dev-1.29

Conversation

@roydejong
Copy link
Copy Markdown
Contributor

@roydejong roydejong commented Apr 1, 2023

This PR adds support for Beat Saber 1.29 where classic master servers are dead:

  • Targets the proposed new MultiplayerCore version with Graph URL patching rather than master server patching
  • Server configs are now based on an ApiUrl e.g. http://master.beattogether.systems:8989
  • Assumes an arbitrary default API port of 8989 and automatically migrates previous server configs
  • Bumps BeatTogether version to 2.1.0 and target Beat Saber 1.29.0

Cross-dependent related PRs

@roydejong
Copy link
Copy Markdown
Contributor Author

@rcelyte Just wanted to tag you in here - this PR would automatically migrate previous BT configs. For BT servers we can assume that they will run their API on `http://<previous_hostname>:<new_arbitrary_api_port>".

If there's something different we should do/assume for BeatUpServers when migrating configs it'd be good to put that in now so we can reduce end user headaches

@rcelyte
Copy link
Copy Markdown

rcelyte commented Apr 1, 2023

BeatUpServer will utilize the existing status URL for graph requests. The classic hostname will not be required or used in the new connection flow.

@roydejong roydejong marked this pull request as ready for review April 9, 2023 22:52
@Kevman95 Kevman95 merged commit 3046292 into master Apr 14, 2023
@rcelyte
Copy link
Copy Markdown

rcelyte commented Apr 15, 2023

If there's something different we should do/assume for BeatUpServers when migrating configs it'd be good to put that in now so we can reduce end user headaches

Guess that fell through? This'll be a rough time explaining to my users why their configs spontaneously broke x_x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants