Add reconnect attempt timer after BT40Device unexpected disconnect#4812
Merged
amtriathlon merged 4 commits intoGoldenCheetah:masterfrom Jan 23, 2026
Merged
Add reconnect attempt timer after BT40Device unexpected disconnect#4812amtriathlon merged 4 commits intoGoldenCheetah:masterfrom
amtriathlon merged 4 commits intoGoldenCheetah:masterfrom
Conversation
Closed
Member
|
Hi Anže, thanks for your contribution, macOS ci build is failing due to missing |
Required to build on macOS
To build on macOS
amtriathlon
added a commit
that referenced
this pull request
Jan 24, 2026
Changes from v3.8-DEV2601 4db88fa Update translation files 663526c Choose cyclist default to no avatar (#4814) f6d4f6a Using "actual activity" instead of "completed activity" (#4813) 253b220 Add Zoomed Elevation Widget to Graphical Meters For simulation workouts without GPS data b0d16d1 Add reconnect attempt timer after BT40Device unexpected disconnect (#4812) c85da47 Fix typo in Nonzero Average Power description 07e673d Selectable show/hide planned activities (#4811) 1a4dd1d Updated Time Range context menu (#4808) 686f431 Revert to Qt 6.5.3 for macOS builds a00e276 Dialog to build filter queries for similar activities (#4805) 749a21d Train mode: Improved readability for ErgFilePlot (#4806) 3e8c6fe Updating power values of planned activities with linked workouts (#4799) 1c69798 Fix Edit menu disappearing when changing languages on macOS (#4797) [publish binaries]
Closed
amtriathlon
added a commit
that referenced
this pull request
Feb 7, 2026
Changes from v3.8-DEV2601 3b5ec90 Fix bug in RideMetadata 9087c0d Combine view indexes and view relevance definitions into single enumerated type (#4795) a0fe8af Planned activities: Keeping track of original date (#4822) 31d8708 Fix default Plan layout a124799 AppVeyor - Refactor Windows build scripts (#4820) d8b10fe Cloud Service creates unnecessary GlobalContext instances (#4823) 40db2bc Standardize how the config is created for releases. (#4784) 6ab9950 AppVeyor - run lupdate on Windows a36f527 Copy & Paste for planned activities on calendar (#4819) dfd932d Fit file import - don't crash on malformed files 2eaf1bc Upgrade Python, Pandas, and SIP versions (#4747) b00d3b7 Update German translation 4db88fa Update translation files 663526c Choose cyclist default to no avatar (#4814) f6d4f6a Using "actual activity" instead of "completed activity" (#4813) 253b220 Add Zoomed Elevation Widget to Graphical Meters For simulation workouts without GPS data b0d16d1 Add reconnect attempt timer after BT40Device unexpected disconnect (#4812) c85da47 Fix typo in Nonzero Average Power description 07e673d Selectable show/hide planned activities (#4811) 1a4dd1d Updated Time Range context menu (#4808) a00e276 Dialog to build filter queries for similar activities (#4805) 749a21d Train mode: Improved readability for ErgFilePlot (#4806) 3e8c6fe Updating power values of planned activities with linked workouts (#4799) 1c69798 Fix Edit menu disappearing when changing languages on macOS (#4797) [publish binaries]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've implemented retry-reconnection to Bluetooth sensors.
Old behavior after an unexpected disconnect of a sensor was to just try to reconnect once. I've made it so it tries to reconnect every 5s, as this makes more sense - if something happened with the sensor, it probably won't be available immediately (happened during my training rides multiple times, for example having to walk away and losing HR for the rest of the ride).
The reconnecting stops once user presses the "Disconnect" button, which I think is what the user would expect.