Skip to content

Selectable show/hide planned activities#4811

Merged
amtriathlon merged 2 commits intoGoldenCheetah:masterfrom
paulj49457:gc-ride-nav-show-hide-planned
Jan 22, 2026
Merged

Selectable show/hide planned activities#4811
amtriathlon merged 2 commits intoGoldenCheetah:masterfrom
paulj49457:gc-ride-nav-show-hide-planned

Conversation

@paulj49457
Copy link
Copy Markdown
Contributor

This PR provides a ride navigator filter to display:

  • all activities
  • only those completed, or
  • just those planned

If a global filter has been set and the ride nav display filter, the ride navigator activities list will display the intersection of the two filters. The default setting is "All", and its last setting will be stored on a per athlete basis.

It aims to resolve issue: #4809

ride nav filter

@thejockl
Copy link
Copy Markdown
Contributor

Nice approach, I like it much better than a separate tree. The following caught my eye:

  • The combobox doesn't open cleanly when using the Breeze QStyle on Linux (the burger menu next to it has similar issues: https://bugs.kde.org/show_bug.cgi?id=473735). Maybe you can hardcode Fusion for Linux?
  • When using fusion, the highlight color matches the splitters background color, this is a little bit confusing
  • The text looks deactivated (both Breeze and Fusion) even when it is not
  • When jumping from calendar to activities view and the current type (planned, completed) is hidden, the activity is shown without being visible in the tree. Since this matches the behaviour when using the filter, I would leave it as is.

Fusion:
Bildschirmfoto_20260121_195101
Bildschirmfoto_20260121_195132

Breeze:
Bildschirmfoto_20260121_195322

@amtriathlon
Copy link
Copy Markdown
Member

Hi Paul, I like how this looks like and behave on Windows!

@paulj49457
Copy link
Copy Markdown
Contributor Author

@thejockl Unfortunately I only have a Windows 11 development environment, so if you have some time please update this PR with any corrections required for MacOs or Linux.

@amtriathlon
Copy link
Copy Markdown
Member

I tried the ci build on macOS and it works as expected the text is dimmed but perhaps it is better that way, "Completed" is too long and it doesn't look good chopped, may we use "Actual" instead?

@thejockl
Copy link
Copy Markdown
Contributor

"Actual" would work for me - but I am not a native speaker (far from). If we rename it, I should follow that term in the calendar.

@paulj49457
Copy link
Copy Markdown
Contributor Author

Fine with me, I'll update the PR

@amtriathlon
Copy link
Copy Markdown
Member

I will merge this, thanks Paul.
Joachim, if you want to restyle for Linux and to change Completed by Actual, feel free to create other PR.
Once we are done I would trigger a new snapshot since I think this will encourage users to Plan activities without the hassle to deal with them in Activities view.

@amtriathlon amtriathlon merged commit 07e673d into GoldenCheetah:master Jan 22, 2026
1 check failed
@paulj49457 paulj49457 deleted the gc-ride-nav-show-hide-planned branch January 24, 2026 16:51
amtriathlon added a commit that referenced this pull request Jan 24, 2026
Changes from v3.8-DEV2601
4db88fa Update translation files
663526c Choose cyclist default to no avatar (#4814)
f6d4f6a Using "actual activity" instead of "completed activity" (#4813)
253b220 Add Zoomed Elevation Widget to Graphical Meters For simulation workouts without GPS data
b0d16d1 Add reconnect attempt timer after BT40Device unexpected disconnect (#4812)
c85da47 Fix typo in Nonzero Average Power description
07e673d Selectable show/hide planned activities (#4811)
1a4dd1d Updated Time Range context menu (#4808)
686f431 Revert to Qt 6.5.3 for macOS builds
a00e276 Dialog to build filter queries for similar activities (#4805)
749a21d Train mode: Improved readability for ErgFilePlot (#4806)
3e8c6fe Updating power values of planned activities with linked workouts (#4799)
1c69798 Fix Edit menu disappearing when changing languages on macOS (#4797)
[publish binaries]
amtriathlon added a commit that referenced this pull request Feb 7, 2026
Changes from v3.8-DEV2601
3b5ec90 Fix bug in RideMetadata
9087c0d Combine view indexes and view relevance definitions into single enumerated type (#4795)
a0fe8af Planned activities: Keeping track of original date (#4822)
31d8708 Fix default Plan layout
a124799 AppVeyor - Refactor Windows build scripts (#4820)
d8b10fe Cloud Service creates unnecessary GlobalContext instances (#4823)
40db2bc Standardize how the config is created for releases. (#4784)
6ab9950 AppVeyor - run lupdate on Windows
a36f527 Copy & Paste for planned activities on calendar (#4819)
dfd932d Fit file import - don't crash on malformed files
2eaf1bc Upgrade Python, Pandas, and SIP versions (#4747)
b00d3b7 Update German translation
4db88fa Update translation files
663526c Choose cyclist default to no avatar (#4814)
f6d4f6a Using "actual activity" instead of "completed activity" (#4813)
253b220 Add Zoomed Elevation Widget to Graphical Meters For simulation workouts without GPS data
b0d16d1 Add reconnect attempt timer after BT40Device unexpected disconnect (#4812)
c85da47 Fix typo in Nonzero Average Power description
07e673d Selectable show/hide planned activities (#4811)
1a4dd1d Updated Time Range context menu (#4808)
a00e276 Dialog to build filter queries for similar activities (#4805)
749a21d Train mode: Improved readability for ErgFilePlot (#4806)
3e8c6fe Updating power values of planned activities with linked workouts (#4799)
1c69798 Fix Edit menu disappearing when changing languages on macOS (#4797)
[publish binaries]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Planned Activities in Activities View sidebar

3 participants