Don't describe progress-tree-log as a default feature#41
Merged
EliahKagan merged 1 commit intoGitoxideLabs:mainfrom Jun 12, 2025
Merged
Don't describe progress-tree-log as a default feature#41EliahKagan merged 1 commit intoGitoxideLabs:mainfrom
progress-tree-log as a default feature#41EliahKagan merged 1 commit intoGitoxideLabs:mainfrom
Conversation
Since it is no longer a default feature as of version 30.0.0 (GitoxideLabs#39).
3 tasks
Member
Author
|
@Byron It seems to me that still having "(default)" on the feature name in the documentation--while small, and not affecting functionality--could be very confusing, since it's not a default feature anymore. Would it be reasonable to release 30.0.1 just for the documentation fix? (#40 also described another problem, but that problem was actually fixed already before the release and I shouldn't have included it; I didn't notice that the fix was in place. Sorry about the confusion.) |
progress-tree-log as a default featureprogress-tree-log as a default feature
EliahKagan
added a commit
to EliahKagan/prodash
that referenced
this pull request
Jun 12, 2025
cf70e4a (GitoxideLabs#41) fixed it in the documentation comments in `lib.rs`, but it had still been listed as a default in the readme, noted in: GitoxideLabs#39 (comment)
Member
Author
|
Although I tried to search for and examine every occurrence of I've fixed that in #42. I think that's everything that needs to be updated for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40
This removes the parenthetical characterization of
progress-tree-logas a default feature inlib.rsdocumentation comments, since it is no longer a default feature since #39 (30.0.0).