feature progress-tree-log should not be default#39
Conversation
when combined with gix, this feature cannot be removed.
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot, and sorry for the hassle. I simply wasn't aware.
|
The new release is available here: https://github.com/GitoxideLabs/prodash/releases/tag/v30.0.0 |
Since it is no longer a default feature as of version 30.0.0 (GitoxideLabs#39).
|
Ooh! Thanks for the merge :) |
|
I noticed the docs & README still label it as default, might want to mix a fix for that in with the next patch version (whenever it comes out) |
cf70e4a (GitoxideLabs#41) fixed it in the documentation comments in `lib.rs`, but it had still been listed as a default in the readme, noted in: GitoxideLabs#39 (comment)
Thanks! I think #41 and #42 fix this now (though the online docs won't be updated until a new release is made). |
|
Thanks a lot for the quick fixes and your support! |
|
And finally, here is the fixed release: |
|
Thanks! I think that URL is for a release of the |
|
Lol, pasted the wrong thing? Haha. |
I propose
progress-tree-logshould not be a default feature, here are my reasons:prodashandgixin the same cargo project, it is impossible to remove progress-tree-log without cargo patching one of them.INFOlogs fill up the terminal space where the progress bar is rendering. It also floods the progress bars existing messages that are already printed, effectively duplicating them.Most should believe this is not default behavior for many project. I am not sure how to announce this change as it may be breaking for some users (breaking is a stretch, it just wont log. looking at the docs it is pretty easy to find that you would have to enable this feature)
Please consider this change as it would greatly help many users.
Thanks!