Fix #2132 Tab switch is broken#2133
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @allyoucanmap, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a reported issue where the tab switching functionality within the details panel was broken. It resolves this by implementing a robust state management solution using Redux, ensuring that the selected tab's state is consistently tracked and updated across interactions, thereby fixing the navigation behavior.
Highlights
- State Management Integration: Introduced Redux state management for the
DetailsPanelcomponent to track and manage the currently selected tab. This involves importing new selectors (getDetailPanelTab) and action creators (setDetailPanelTab) from the@mapstore/frameworklibrary. - Component Prop Updates: The
DetailsPanelfunctional component now acceptsselectedTabandonSelectTabas props, which are then passed down to its child component,DetailsInfo(which is enhanced withwithScrollableTabs). - Redux Connection: The
ConnectedDetailsPanelcomponent has been updated to map theselectedTabstate from the Redux store usinggetDetailPanelTaband to dispatch thesetDetailPanelTabaction via theonSelectTabprop, ensuring the tab state is centrally managed.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
| selectedTab, | ||
| onSelectTab |
There was a problem hiding this comment.
Moving the selected tab state to Redux means it will persist when the displayed resource changes. This can lead to issues if the new resource doesn't have the previously selected tab. To avoid this, consider resetting the selected tab whenever the resource changes using a useEffect hook in the DetailsPanel component:
import React, { useEffect } from 'react';
function DetailsPanel({ resource: resourceProp, onSelectTab, ...rest }) {
const resource = parseCatalogResource(resourceProp);
useEffect(() => {
onSelectTab(undefined);
}, [resource?.pk, onSelectTab]);
// ... component logic
}There was a problem hiding this comment.
Note: this is already managed in the internal component DetailsInfo
* commit '4f51a4366a5c092e9eabdf84c84a02bfb6c6b66c': [create-pull-request] automated change (GeoNode#2141) Translate resource type in the detail panel (GeoNode#2108) [create-pull-request] automated change (GeoNode#2140) GeoNode#2109: Add Edit Permissions to resource menu (GeoNode#2111) GeoNode#2110: Fix - Pending prompt inside viewer (GeoNode#2114) GeoNode#2113: Fix - Incorrect url formation on copy resource url in resource grid page (GeoNode#2115) [create-pull-request] automated change (GeoNode#2139) GeoNode#2119 - Update client to show exported data from layer download (GeoNode#2120) GeoNode#2122: Fix - MS search bar is shifted when plugin panel is visible (GeoNode#2124) GeoNode#2135: Fix - View menu is hidden when a mapviewer is connected to a map (GeoNode#2137) GeoNode#2136: Update loader and upload processing buttons (GeoNode#2138) [create-pull-request] automated change (GeoNode#2134) Fix GeoNode#2132 Tab switch is broken (GeoNode#2133) [create-pull-request] automated change (GeoNode#2131) Fix GeoNode#2129 Upgrade MapStore to include the fix for Download (GeoNode#2130) [create-pull-request] automated change (GeoNode#2127) Enhance useDetectClickOut with extra nodes to cross reference (GeoNode#2123) [create-pull-request] automated change (GeoNode#2118) Include the new LayerDownload in GeoNode client (GeoNode#2112)
No description provided.