#2119 - Update client to show exported data from layer download#2120
#2119 - Update client to show exported data from layer download#2120allyoucanmap merged 1 commit intoGeoNode:masterfrom
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @dsuren1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to integrate the display of exported data from the Layer Download functionality directly into the GeoNode client's ActionNavbar. This change mirrors a recent update in MapStore, where similar functionality was moved to its BrandNavbar, ensuring a consistent user experience for accessing asynchronous layer export data across all supported resource types within GeoNode.
Highlights
- Relocation of Export Data Display: The component responsible for displaying exported layer data has been moved from its previous location (implied to be similar to MapStore's
BrandNavbar) to GeoNode'sActionNavbar. - Integration of Export Data Results: A new React component,
LayerDownloadExportDataResultsComponent, has been introduced and connected to the Redux store to manage and display the status and results of asynchronous layer data exports. - Enhanced User Experience: By placing the export data display in the
ActionNavbar, users can now consistently monitor and access their exported layer data, regardless of the resource type.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request successfully integrates the layer download export results into the ActionNavbar. The changes are well-structured, following existing patterns for creating connected components and configuring plugins in MapStore. The new component is correctly wired to the Redux store, and its placement in the UI is controlled explicitly using the position property in the plugin configuration. The related change to add a position to the FullScreenPlugin is a good practice for ensuring a predictable layout. The implementation is clean and correct.
* commit '6dcf9b2748da47b760711e5d743535d3ff71debc': GeoNode#2109: Add Edit Permissions to resource menu (GeoNode#2111) GeoNode#2110: Fix - Pending prompt inside viewer (GeoNode#2114) GeoNode#2113: Fix - Incorrect url formation on copy resource url in resource grid page (GeoNode#2115) [create-pull-request] automated change (GeoNode#2139) GeoNode#2119 - Update client to show exported data from layer download (GeoNode#2120) GeoNode#2122: Fix - MS search bar is shifted when plugin panel is visible (GeoNode#2124) GeoNode#2135: Fix - View menu is hidden when a mapviewer is connected to a map (GeoNode#2137) GeoNode#2136: Update loader and upload processing buttons (GeoNode#2138)
* commit '4f51a4366a5c092e9eabdf84c84a02bfb6c6b66c': [create-pull-request] automated change (GeoNode#2141) Translate resource type in the detail panel (GeoNode#2108) [create-pull-request] automated change (GeoNode#2140) GeoNode#2109: Add Edit Permissions to resource menu (GeoNode#2111) GeoNode#2110: Fix - Pending prompt inside viewer (GeoNode#2114) GeoNode#2113: Fix - Incorrect url formation on copy resource url in resource grid page (GeoNode#2115) [create-pull-request] automated change (GeoNode#2139) GeoNode#2119 - Update client to show exported data from layer download (GeoNode#2120) GeoNode#2122: Fix - MS search bar is shifted when plugin panel is visible (GeoNode#2124) GeoNode#2135: Fix - View menu is hidden when a mapviewer is connected to a map (GeoNode#2137) GeoNode#2136: Update loader and upload processing buttons (GeoNode#2138) [create-pull-request] automated change (GeoNode#2134) Fix GeoNode#2132 Tab switch is broken (GeoNode#2133) [create-pull-request] automated change (GeoNode#2131) Fix GeoNode#2129 Upgrade MapStore to include the fix for Download (GeoNode#2130) [create-pull-request] automated change (GeoNode#2127) Enhance useDetectClickOut with extra nodes to cross reference (GeoNode#2123) [create-pull-request] automated change (GeoNode#2118) Include the new LayerDownload in GeoNode client (GeoNode#2112)
Description
This PR updates the client to display exported data from Layer Download in the ActionNavbar, aligning with the recent change in MapStore where this functionality was moved to the BrandNavbar.
Since ActionNavbar serves as the GeoNode equivalent, the export component has been moved there, ensuring all supported resource types can access asynchronous layer export data consistently
Screenshot