Fix bug that stops Figure.coast from plotting with only dcw#910
Merged
Fix bug that stops Figure.coast from plotting with only dcw#910
Conversation
weiji14
approved these changes
Feb 16, 2021
Member
There was a problem hiding this comment.
This PR is fine when tested locally. The Style Checks pylint error is due to pylint==2.6.1 and is unrelated (see pylint-dev/pylint#4096), I'll make a quick pin to pylint==2.6.0 in a separate PR (at #911) and we can merge this one afterwards.
Edit: pylint==2.6.2 is released so all good to merge now.
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…appingTools#910) GMT allows coast to plot with the `-E` argument and no other colors set, but PyGMT would raise an error if `dcw` was the only argument. This is a fix for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GMT allows coast to plot with the
-Eargument and no other colors set, but PyGMT would raise an error ifdcwwas the only argument. This is a fix for that.Fixes #903
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version