Skip to content

Pin pylint to 2.6.0#911

Closed
weiji14 wants to merge 1 commit intomasterfrom
pylint-2.6.0
Closed

Pin pylint to 2.6.0#911
weiji14 wants to merge 1 commit intomasterfrom
pylint-2.6.0

Conversation

@weiji14
Copy link
Member

@weiji14 weiji14 commented Feb 16, 2021

Description of proposed changes

Temporary fix for AttributeError: module 'pylint.checkers.utils' has no attribute 'is_call_of_name'. Workaround pylint-dev/pylint#4096.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

Temporary fix for `AttributeError: module 'pylint.checkers.utils' has no attribute 'is_call_of_name'`
@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Feb 16, 2021
@weiji14 weiji14 requested a review from a team February 16, 2021 09:48
@weiji14
Copy link
Member Author

weiji14 commented Feb 16, 2021

Nevermind, pylint==2.6.2 has been released 😄

@weiji14 weiji14 closed this Feb 16, 2021
@weiji14 weiji14 removed the request for review from a team February 16, 2021 10:36
@weiji14 weiji14 deleted the pylint-2.6.0 branch February 16, 2021 10:36
@seisman
Copy link
Member

seisman commented Feb 16, 2021

Just wondering do we want to pin versions of the dependencies (especially for tools like black, blackdoc, docformatter, flake8, isort and pylint) to avoid surprising failures. The pinned versions can be automatically updated by dependabot.

@weiji14
Copy link
Member Author

weiji14 commented Feb 16, 2021

Just wondering do we want to pin versions of the dependencies (especially for tools like black, blackdoc, docformatter, flake8, isort and pylint) to avoid surprising failures. The pinned versions can be automatically updated by dependabot.

They actually fixed the pylint issue quite fast (in an hour or so), and it doesn't happen often. Probably revisit this (pinning dependencies) another time if it starts to become a regular issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants