Add args_in_kwargs function#791
Merged
seisman merged 21 commits intoGenericMappingTools:masterfrom Jan 15, 2021
Merged
Conversation
seisman
reviewed
Jan 11, 2021
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
weiji14
reviewed
Jan 13, 2021
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
seisman
reviewed
Jan 13, 2021
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Member
|
/format |
seisman
reviewed
Jan 15, 2021
seisman
reviewed
Jan 15, 2021
seisman
reviewed
Jan 15, 2021
Member
|
/format |
seisman
approved these changes
Jan 15, 2021
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com> Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #787, the
args_in_kwargsfunction is used to determine if at least one of the required arguments are passed to the function before the arguments are passed to the GMT API. The function takes a list of required arguments, using the GMT short name aliases, and a dictionary of the kwargs, which is the format that is returned by the _preprocess function in BasePlotting. It returns a Boolean value, with the idea that the plotting function raises the GMTInvalidInput Error if it returnsFalse.