Add GMTInvalidInput Error for Figure.coast#787
Merged
seisman merged 11 commits intoGenericMappingTools:masterfrom Jan 20, 2021
Merged
Add GMTInvalidInput Error for Figure.coast#787seisman merged 11 commits intoGenericMappingTools:masterfrom
seisman merged 11 commits intoGenericMappingTools:masterfrom
Conversation
…usly returned a GMtClibError that specified GMT arguments; added GMTInvalidInput to use PyGMT arguments
Member
|
It seems there is a trailing whitespace near Line 154. Please fix it manually. |
Contributor
Author
|
@seisman Updated. |
seisman
reviewed
Jan 3, 2021
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Contributor
Author
|
/format |
seisman
reviewed
Jan 18, 2021
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Member
|
/format |
seisman
approved these changes
Jan 20, 2021
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
* Add error raising to coast function in base_plotting.py. Error previously returned a GMtClibError that specified GMT arguments; added GMTInvalidInput to use PyGMT arguments * Add test for updated error in test_coast.py Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com> Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Figure.coast returns a GMTCLibError if the required arguments are not included. The error lists the GMT argument names instead of the PyGMT argument names. I added an if statement that will raise a GMTInvalidInput Error if the conditions aren't met and a test.
I left
CandQas is because they do not have an alias on the PyGMT master branch yet.