Skip to content

Add fractures_06.txt to cache data#1097

Merged
seisman merged 3 commits intomasterfrom
cache-fractures06
Mar 22, 2021
Merged

Add fractures_06.txt to cache data#1097
seisman merged 3 commits intomasterfrom
cache-fractures06

Conversation

@michaelgrund
Copy link
Member

@michaelgrund michaelgrund commented Mar 22, 2021 •
edited
Loading

As suggested in #794 this PR adds the remote file fractures_06.txt to the cache workflow which is used to generate e.g. the gallery example for the upcoming rose wrapper. It's also heavily used for the testing of rose.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrund
Add fractures_06.txt to cache data
e67a873 
As suggested in #794 this PR adds the remote file fractures_06.txt to the cache workflow which is used to generate e.g. the gallery example for the upcoming rose warpper.
@michaelgrund michaelgrund added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Mar 22, 2021
@michaelgrund michaelgrund requested review from seisman and weiji14 March 22, 2021 11:51
@michaelgrund michaelgrund mentioned this pull request Mar 22, 2021
Merged
5 tasks
@michaelgrund michaelgrund deleted the cache-fractures06 branch March 22, 2021 17:31
@seisman seisman restored the cache-fractures06 branch March 22, 2021 17:41
@seisman seisman reopened this Mar 22, 2021
@seisman
Copy link
Member

seisman commented Mar 22, 2021

I'm reopening the PR because the data file still needs to be cached before PR #1101.

@seisman
Copy link
Member

seisman commented Mar 22, 2021 •
edited
Loading

The "Cache Data" workflow runs every Sunday. To cache the data before the next scheduled run, you need to uncomment the pull_request: line and commit the changes, wait for the CI run to finish, and comment the pull_request: line again.

See the commits history in RP #1085 for an example.

@michaelgrund
Copy link
Member Author

michaelgrund commented Mar 22, 2021 •
edited
Loading

The "Cache Data" workflow runs every Sunday. To cache the data before the next scheduled run, you need to uncomment the pull_request: line and commit the changes, wait for the CI run to finish, and comment the pull_request: line again.

See the commits history in RP #1085 for an example.

Thanks for guiding me @seisman 😉.

Edit: done

@seisman seisman added this to the 0.4.0 milestone Mar 22, 2021
@seisman seisman merged commit cc5010e into master Mar 22, 2021
@seisman seisman deleted the cache-fractures06 branch March 22, 2021 19:26
@michaelgrund michaelgrund mentioned this pull request Aug 3, 2021
Merged
5 tasks
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@michaelgrund
Add fractures_06.txt to cache data (GenericMappingTools#1097)
4eb599a 
The remote file fractures_06.txt is used to generate e.g. the gallery example 
for the upcoming rose wrapper.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seisman seisman seisman approved these changes

@weiji14 weiji14 Awaiting requested review from weiji14

Assignees

No one assigned

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Milestone

0.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelgrund @seisman