Skip to content

CI: Add srtm_tiles.nc to cache data#1085

Merged
weiji14 merged 4 commits intomasterfrom
cache-srtm-tiles
Mar 21, 2021
Merged

CI: Add srtm_tiles.nc to cache data#1085
weiji14 merged 4 commits intomasterfrom
cache-srtm-tiles

Conversation

@seisman
Copy link
Member

@seisman seisman commented Mar 20, 2021

Description of proposed changes

GMT needs the srtm_tiles.nc file to know if a tile is on land or in ocean,
when using 01s and 03s earth relief data.

Without this file, sometimes CI jobs may fail (e.g., https://github.com/GenericMappingTools/pygmt/pull/1084/checks?check_run_id=2156130407)

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman marked this pull request as ready for review March 20, 2021 18:53
@seisman seisman added this to the 0.4.0 milestone Mar 20, 2021
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Mar 20, 2021
@seisman seisman requested a review from weiji14 March 20, 2021 18:53
@weiji14 weiji14 merged commit ef87016 into master Mar 21, 2021
@weiji14 weiji14 deleted the cache-srtm-tiles branch March 21, 2021 09:34
@seisman seisman mentioned this pull request Mar 22, 2021
5 tasks
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
GMT needs the srtm_tiles.nc file to know
if a tile is on land or in the ocean, when
using 01s and 03s earth relief data. Without
this file, sometimes CI jobs may fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants