Conversation
Given we now merged in #7887 we need to update -o, as -i.
Contributor
|
Hi Paul,
I'm not sure what this is about, but looking at your code change on the
git page I wonder if you should have preserved the original 'o'
short-option string in the modified long-option entry rather than changing
it to 'i'?
I'm working at ARL today so I can't really look at anything easily, sorry.
Roger
… @rbdavis, given we now merged in #7887 we need to update -o, as -i.
You can view, comment on, or merge this pull request online at:
#7893
-- Commit Summary --
* Update long-options for -o
-- File Changes --
M src/gmt_common_longoptions.h (4)
-- Patch Links --
https://github.com/GenericMappingTools/gmt/pull/7893.patch
https://github.com/GenericMappingTools/gmt/pull/7893.diff
--
Reply to this email directly or view it on GitHub:
#7893
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
Sorry, forgot to change 'i' to 'o'...
rbdavis
approved these changes
Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rbdavis, given we now merged in #7887 we need to update -o, as -i.