Skip to content

Enhance -o to accept the same transformations as -i#7887

Merged
PaulWessel merged 10 commits intomasterfrom
enable-o-transformations
Oct 9, 2023
Merged

Enhance -o to accept the same transformations as -i#7887
PaulWessel merged 10 commits intomasterfrom
enable-o-transformations

Conversation

@PaulWessel
Copy link
Member

See this recent forum post for background. Long overdue upgrade to modify output columns via transformations as we are able to do on input. This is particularly useful when writing table output that originate from grids (e.g., grdtrack). I have updated the -o parser (shared code with -i parser), synopsis, documentation, and added a test script gmt_core/gmt_io_cols.sh which compares output from convert with the same settings for -i to the output from -o. Passes.
WIP since I want some more testing first.

@PaulWessel PaulWessel added enhancement Improving an existing feature add-changelog Add PR to the changelog labels Oct 8, 2023
@PaulWessel PaulWessel added this to the 6.5.0 milestone Oct 8, 2023
@PaulWessel PaulWessel self-assigned this Oct 8, 2023
Copy link
Member

@Esteban82 Esteban82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I test it with #6053

@PaulWessel PaulWessel changed the title WIP Enhance -o to accept the same transformations as -i Enhance -o to accept the same transformations as -i Oct 9, 2023
@Esteban82
Copy link
Member

Could I merge this?

@PaulWessel PaulWessel merged commit 6712608 into master Oct 9, 2023
@PaulWessel PaulWessel deleted the enable-o-transformations branch October 9, 2023 20:15
PaulWessel added a commit that referenced this pull request Oct 9, 2023
Given we now merged in #7887 we need to update -o, as -i.
@PaulWessel
Copy link
Member Author

Already merged

rbdavis pushed a commit that referenced this pull request Oct 10, 2023
* Update long-options for -o

Given we now merged in #7887 we need to update -o, as -i.

* Update gmt_common_longoptions.h

Sorry, forgot to change 'i' to 'o'...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add-changelog Add PR to the changelog enhancement Improving an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants